Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1294883002: Revert of [Android] Add a java.lang.System wrapper. (Closed)

Created:
5 years, 4 months ago by jdduke (slow)
Modified:
5 years, 4 months ago
Reviewers:
danakj, rmcilroy, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, Deprecated (see juliatuttle)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add a java.lang.System wrapper. (patchset #2 id:20001 of https://codereview.chromium.org/1283543003/ ) Reason for revert: This doesn't actually work. Original issue's description: > [Android] Add a java.lang.System wrapper. > > Add a basic JNI wrapper for java.lang.System. Expose just the > getProperty() method, eliminating a deprecated __system_property_get > usage as well as a seperate System.getProperty wrapper. > > The remaining uses of __system_property_get will be removed in > https://codereview.chromium.org/1236283002/. > > BUG=392196, 392191 > > Committed: https://crrev.com/130c6bf9db16a69fca8488da8e15e978470e7e8b > Cr-Commit-Position: refs/heads/master@{#343245} TBR=rmcilroy@chromium.org,danakj@chromium.org,davidben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392196, 392191 Committed: https://crrev.com/e5c1ef11a048c3650283b9a7bbb62d4d6e85e927 Cr-Commit-Position: refs/heads/master@{#343430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -92 lines) Patch
M base/BUILD.gn View 3 chunks +0 lines, -9 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D base/android/java_system.h View 1 chunk +0 lines, -30 lines 0 comments Download
D base/android/java_system.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/android/java/src/org/chromium/net/ProxyChangeListener.java View 1 chunk +5 lines, -0 lines 0 comments Download
M net/dns/dns_config_service_posix.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jdduke (slow)
Created Revert of [Android] Add a java.lang.System wrapper.
5 years, 4 months ago (2015-08-14 18:05:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294883002/1
5 years, 4 months ago (2015-08-14 18:05:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 18:06:45 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 18:07:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5c1ef11a048c3650283b9a7bbb62d4d6e85e927
Cr-Commit-Position: refs/heads/master@{#343430}

Powered by Google App Engine
This is Rietveld 408576698