Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1294833004: Revert of [tracing] Add browser-side tests for memory dumps. (Closed)

Created:
5 years, 4 months ago by Mike Lerman
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Add browser-side tests for memory dumps. (patchset #2 id:20001 of https://codereview.chromium.org/1295753002/ ) Reason for revert: This CL flakily causes failures on try bots, specifically in SingleProcessMemoryTracingTest.BrowserInitiatedSingleDump: c:\b\build\slave\win_builder__dbg_\build\src\content\browser\tracing\memory_tracing_browsertest.cc(142): error: Mock function called more times than expected - returning default value. Function call: OnMemoryDump(@3286BA0C 4-byte object \u003C01-00 00-00>, 3286B920) Returns: false Expected: to be called once Actual: called twice - over-saturated and active On Win7 - https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40855 and ../../content/browser/tracing/memory_tracing_browsertest.cc:148: Failure Value of: last_callback_success_ Actual: false Expected: true on Mac 10.8: https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/6628 Original issue's description: > [tracing] Add browser-side tests for memory dumps. > > This is a rebase of https://codereview.chromium.org/1064413002. The > `OverlappingRequests` test has been removed. > > Committed: https://crrev.com/a4c2539f13510a650d51e65204ea52426979659c > Cr-Commit-Position: refs/heads/master@{#343408} TBR=primiano@chromium.org,dsinclair@chromium.org,ruuda@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fd3605751e24132df3e0357433b16935879ce0fe Cr-Commit-Position: refs/heads/master@{#343456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -213 lines) Patch
D content/browser/tracing/memory_tracing_browsertest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Lerman
Created Revert of [tracing] Add browser-side tests for memory dumps.
5 years, 4 months ago (2015-08-14 19:04:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294833004/1
5 years, 4 months ago (2015-08-14 19:05:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 19:06:27 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 19:07:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd3605751e24132df3e0357433b16935879ce0fe
Cr-Commit-Position: refs/heads/master@{#343456}

Powered by Google App Engine
This is Rietveld 408576698