Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1294803005: Move ServiceWorker public headers to public/*/modules/serviceworker (1.5/3) (Closed)

Created:
5 years, 4 months ago by kinuko
Modified:
5 years, 4 months ago
Reviewers:
tkent, kinuko (google)
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move ServiceWorker public headers to public/*/modules/serviceworker (1.5/3) The change was supposed to be made in three-sided patch: [1] (blink) https://codereview.chromium.org/1262943002/ [2] (chromium) https://codereview.chromium.org/1254023006/ [3] (blink) https://codereview.chromium.org/1262603004/ But the change [1] needed to duplicate one header file (rather than having a forwarding include) and a changes made between [1] and [2] wasn't copied to the dup'ed file. This change's making the same change made in the old location to the new location. I also added a FIXME comment so that we could keep the files in sync until we land [2]. BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M public/platform/WebServiceWorkerResponseType.h View 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/modules/serviceworker/WebServiceWorkerResponseType.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kinuko
Kent-san, could you review this? (Feeling bad for bringing this confusion, this should be cleaned ...
5 years, 4 months ago (2015-08-18 12:00:11 UTC) #2
tkent
On 2015/08/18 12:00:11, kinuko wrote: > the change [1] needed to duplicate one header file ...
5 years, 4 months ago (2015-08-19 00:04:21 UTC) #3
kinuko
On 2015/08/19 00:04:21, tkent wrote: > On 2015/08/18 12:00:11, kinuko wrote: > > the change ...
5 years, 4 months ago (2015-08-19 00:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294803005/1
5 years, 4 months ago (2015-08-19 00:09:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/121405)
5 years, 4 months ago (2015-08-19 00:21:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294803005/1
5 years, 4 months ago (2015-08-19 00:34:01 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 01:05:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200774

Powered by Google App Engine
This is Rietveld 408576698