[Interpreter] Add implementations for load immediate bytecodes.

src/compiler/interpreter-assembler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/interpreter-assembler.h"
 
 #include <ostream>
 
 #include "src/compiler/graph.h"
 #include "src/compiler/instruction-selector.h"
@@ skipping 116 matching lines @@
       kMachInt8, BytecodeArrayTaggedPointer(),
       raw_assembler_->IntPtrAdd(BytecodeOffset(), Int32Constant(1 + delta)));
   // Ensure that we sign extend to full pointer size
   if (kPointerSize == 8) {
     load = raw_assembler_->ChangeInt32ToInt64(load);
   }
   return load;
 }
 
 
+Node* InterpreterAssembler::BytecodeOperandImm8(int delta) {

[oth, 2015/08/17 10:49:02]

Suggest renaming delta for clarity - operand_index/operand_number.

[rmcilroy, 2015/08/18 13:06:22]

Done.

+  DCHECK_EQ(interpreter::OperandType::kImm8,
+            interpreter::Bytecodes::GetOperandType(bytecode_, delta));
+  return BytecodeOperandSignExtended(delta);
+}
+
+
+Node* InterpreterAssembler::BytecodeOperandReg(int delta) {
+  DCHECK_EQ(interpreter::OperandType::kReg,
+            interpreter::Bytecodes::GetOperandType(bytecode_, delta));
+  return BytecodeOperandSignExtended(delta);
+}
+
+
+Node* InterpreterAssembler::Int32Constant(int value) {
+  return raw_assembler_->Int32Constant(value);
+}
+
+
+Node* InterpreterAssembler::NumberConstant(double value) {
+  return raw_assembler_->NumberConstant(value);
+}
+
+
+Node* InterpreterAssembler::HeapConstant(Unique<HeapObject> object) {
+  return raw_assembler_->HeapConstant(object);
+}
+
+
+Node* InterpreterAssembler::SmiShiftBitsConstant() {
+  return Int32Constant(kSmiShiftSize + kSmiTagSize);
+}
+
+
+Node* InterpreterAssembler::SmiTag(Node* value) {
+  return raw_assembler_->WordShl(value, SmiShiftBitsConstant());
+}
+
+
+Node* InterpreterAssembler::SmiUntag(Node* value) {
+  return raw_assembler_->WordSar(value, SmiShiftBitsConstant());
+}
+
+
 void InterpreterAssembler::Return() {
   Node* exit_trampoline_code_object =
       HeapConstant(Unique<HeapObject>::CreateImmovable(
           isolate()->builtins()->InterpreterExitTrampoline()));
   // If the order of the parameters you need to change the call signature below.
   STATIC_ASSERT(0 == Linkage::kInterpreterAccumulatorParameter);
   STATIC_ASSERT(1 == Linkage::kInterpreterRegisterFileParameter);
   STATIC_ASSERT(2 == Linkage::kInterpreterBytecodeOffsetParameter);
   STATIC_ASSERT(3 == Linkage::kInterpreterBytecodeArrayParameter);
   STATIC_ASSERT(4 == Linkage::kInterpreterDispatchTableParameter);
@@ skipping 62 matching lines @@
 CallDescriptor* InterpreterAssembler::call_descriptor() const {
   return raw_assembler_->call_descriptor();
 }
 
 
 Schedule* InterpreterAssembler::schedule() {
   return raw_assembler_->schedule();
 }
 
 
-Node* InterpreterAssembler::Int32Constant(int value) {
-  return raw_assembler_->Int32Constant(value);
-}
-
-
-Node* InterpreterAssembler::NumberConstant(double value) {
-  return raw_assembler_->NumberConstant(value);
-}
-
-
-Node* InterpreterAssembler::HeapConstant(Unique<HeapObject> object) {
-  return raw_assembler_->HeapConstant(object);
-}
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8