Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: src/heap/heap.h

Issue 1294763004: [heap] Hide GCTracer inside the heap component. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index d4248079e72dbb1bc57f1c3af8b644ca86ea1900..da52d3ce8df7ef4ec29cc58239c3a709e8b1db87 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -12,7 +12,6 @@
#include "src/assert-scope.h"
#include "src/globals.h"
#include "src/heap/gc-idle-time-handler.h"
-#include "src/heap/gc-tracer.h"
#include "src/heap/incremental-marking.h"
#include "src/heap/mark-compact.h"
#include "src/heap/memory-reducer.h"
@@ -1344,7 +1343,7 @@ class Heap {
void ClearNormalizedMapCaches();
- GCTracer* tracer() { return &tracer_; }
+ GCTracer* tracer() { return tracer_; }
Michael Lippautz 2015/08/20 15:09:07 Suggestion: GCTracer& ?
Michael Starzinger 2015/08/20 15:46:32 Acknowledged. As discussed offline, let's do this
// Returns the size of objects residing in non new spaces.
intptr_t PromotedSpaceSizeOfObjects();
@@ -2097,7 +2096,7 @@ class Heap {
int deferred_counters_[v8::Isolate::kUseCounterFeatureCount];
- GCTracer tracer_;
+ GCTracer* tracer_;
// Creates and installs the full-sized number string cache.
int FullSizeNumberStringCacheLength();
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698