Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: pkg/watcher/test/directory_watcher/mac_os_test.dart

Issue 129473003: Use stream matchers to unflake the mac OS watcher tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/watcher/test/directory_watcher/linux_test.dart ('k') | pkg/watcher/test/directory_watcher/shared.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/watcher/test/directory_watcher/mac_os_test.dart
diff --git a/pkg/watcher/test/directory_watcher/mac_os_test.dart b/pkg/watcher/test/directory_watcher/mac_os_test.dart
index 077787a29e6c624bb364fe556a6384af7ef6d18c..43567f0e79c07850347940481c5b2924eebc6460 100644
--- a/pkg/watcher/test/directory_watcher/mac_os_test.dart
+++ b/pkg/watcher/test/directory_watcher/mac_os_test.dart
@@ -36,24 +36,26 @@ main() {
expectAddEvent("dir/newer.txt");
});
- test('emits events for many nested files moved out then immediately back in',
- () {
- withPermutations((i, j, k) =>
- writeFile("dir/sub/sub-$i/sub-$j/file-$k.txt"));
-
- startWatcher(dir: "dir");
-
- renameDir("dir/sub", "sub");
- renameDir("sub", "dir/sub");
-
- inAnyOrder(() {
- withPermutations((i, j, k) =>
- expectRemoveEvent("dir/sub/sub-$i/sub-$j/file-$k.txt"));
- });
-
- inAnyOrder(() {
- withPermutations((i, j, k) =>
- expectAddEvent("dir/sub/sub-$i/sub-$j/file-$k.txt"));
- });
- });
+ // TODO(nweiz): re-enable this when issue 16003 is fixed.
+ // test('emits events for many nested files moved out then immediately back in',
+ // () {
+ // withPermutations((i, j, k) =>
+ // writeFile("dir/sub/sub-$i/sub-$j/file-$k.txt"));
+
+ // startWatcher(dir: "dir");
+
+ // renameDir("dir/sub", "sub");
+ // renameDir("sub", "dir/sub");
+
+ // allowEither(() {
+ // inAnyOrder(withPermutations((i, j, k) =>
+ // isRemoveEvent("dir/sub/sub-$i/sub-$j/file-$k.txt")));
+
+ // inAnyOrder(withPermutations((i, j, k) =>
+ // isAddEvent("dir/sub/sub-$i/sub-$j/file-$k.txt")));
+ // }, () {
+ // inAnyOrder(withPermutations((i, j, k) =>
+ // isModifyEvent("dir/sub/sub-$i/sub-$j/file-$k.txt")));
+ // });
+ // });
}
« no previous file with comments | « pkg/watcher/test/directory_watcher/linux_test.dart ('k') | pkg/watcher/test/directory_watcher/shared.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698