Create GrQuad

Create GrQuad

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ae5b2c623b22b24ea7c0d6200298e5bc366faa63

[joshualitt, 2015-08-19 14:09:39]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-08-19 14:09:39]

ptal, just a couple of methods for now.

[bsalomon, 2015-08-19 14:20:04]

https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h
File src/gpu/GrQuad.h (right):

https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode18
src/gpu/GrQuad.h:18: public:
Constructor from rect?

https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode19
src/gpu/GrQuad.h:19: GrQuad(const GrQuad& that) {
op =?

https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode27
src/gpu/GrQuad.h:27: void map(const SkMatrix& viewMatrix) {
This isn't necessarily a "view" matrix, just a matrix.

https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode36
src/gpu/GrQuad.h:36: operator SkPoint*() {
Hm... not sure I love the auto-conversion to SkPoint*.

[joshualitt, 2015-08-19 14:30:35]

On 2015/08/19 14:20:04, bsalomon wrote:
> https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h
> File src/gpu/GrQuad.h (right):
> 
> https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode18
> src/gpu/GrQuad.h:18: public:
> Constructor from rect?
> 
> https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode19
> src/gpu/GrQuad.h:19: GrQuad(const GrQuad& that) {
> op =?
> 
> https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode27
> src/gpu/GrQuad.h:27: void map(const SkMatrix& viewMatrix) {
> This isn't necessarily a "view" matrix, just a matrix.
> 
> https://codereview.chromium.org/1294713009/diff/1/src/gpu/GrQuad.h#newcode36
> src/gpu/GrQuad.h:36: operator SkPoint*() {
> Hm... not sure I love the auto-conversion to SkPoint*.

feedback incorporated

[bsalomon, 2015-08-19 15:04:51]

https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h
File src/gpu/GrQuad.h (right):

https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode23
src/gpu/GrQuad.h:23: GrQuad(const SkRect& rect) {
explicit

https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode35
src/gpu/GrQuad.h:35: void map(const SkRect& rect, const SkMatrix& matrix) {
The other "map" maps the existing values. This one discards them. Could we give
it a more clear name? setFromMappedRect? Don't love it... but something that
clearly distinguishes the two.

https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode45
src/gpu/GrQuad.h:45: SkPoint* points() {
const version?

[joshualitt, 2015-08-19 15:29:44]

On 2015/08/19 15:04:51, bsalomon wrote:
> https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h
> File src/gpu/GrQuad.h (right):
> 
>
https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode23
> src/gpu/GrQuad.h:23: GrQuad(const SkRect& rect) {
> explicit
> 
>
https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode35
> src/gpu/GrQuad.h:35: void map(const SkRect& rect, const SkMatrix& matrix) {
> The other "map" maps the existing values. This one discards them. Could we
give
> it a more clear name? setFromMappedRect? Don't love it... but something that
> clearly distinguishes the two.
> 
>
https://codereview.chromium.org/1294713009/diff/20001/src/gpu/GrQuad.h#newcode45
> src/gpu/GrQuad.h:45: SkPoint* points() {
> const version?

feedback incorporated

[bsalomon, 2015-08-19 15:40:28]

lgtm

[joshualitt, 2015-08-19 15:41:05]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-08-19 15:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294713009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294713009/40001

[commit-bot: I haz the power, 2015-08-19 15:48:44]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ae5b2c623b22b24ea7c0d6200298e5bc366faa63