Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1294713005: Remove FrameView::m_firstLayoutCallbackPending, nothing uses it. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove FrameView::m_firstLayoutCallbackPending, nothing uses it. This variable is never read except to set it to false, strangely by first checking if its true. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
5 years, 4 months ago (2015-08-14 21:12:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294713005/1
5 years, 4 months ago (2015-08-14 21:13:26 UTC) #4
ojan
lgtm
5 years, 4 months ago (2015-08-14 21:28:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 23:26:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294713005/1
5 years, 4 months ago (2015-08-14 23:48:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 23:53:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200576

Powered by Google App Engine
This is Rietveld 408576698