Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: pkg/scheduled_test/lib/src/schedule.dart

Issue 12947003: Cut down the default timeout in scheduled_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/schedule.dart
diff --git a/pkg/scheduled_test/lib/src/schedule.dart b/pkg/scheduled_test/lib/src/schedule.dart
index abc3675ecc37ae201f7fb26d2ead94f3fc10d6e8..977fc3f7d747c1036026df2d10f53f111dfd1d34 100644
--- a/pkg/scheduled_test/lib/src/schedule.dart
+++ b/pkg/scheduled_test/lib/src/schedule.dart
@@ -87,7 +87,10 @@ class Schedule {
TaskQueue _currentQueue;
/// The time to wait before terminating a task queue for inactivity. Defaults
- /// to 30 seconds. This can be set to `null` to disable timeouts entirely.
+ /// to 5 seconds. This can be set to `null` to disable timeouts entirely. Note
+ /// that the timeout is the maximum time a task is allowed between
+ /// interactions with the schedule, *not* the maximum time an entire test is
+ /// allowed. See also [heartbeat].
///
/// If a task queue times out, an error will be raised that can be handled as
/// usual in the [onException] and [onComplete] queues. If [onException] times
@@ -97,7 +100,7 @@ class Schedule {
/// If a task times out and then later completes with an error, that error
/// cannot be handled. The user will still be notified of it.
Duration get timeout => _timeout;
- Duration _timeout = new Duration(seconds: 30);
+ Duration _timeout = new Duration(seconds: 5);
set timeout(Duration duration) {
_timeout = duration;
heartbeat();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698