Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1294673006: Update GatherPixelRefDevice to the new SkImage/SkPixelRef API (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
Reviewers:
*vmpstr, robertphillips, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GatherPixelRefDevice to the new SkImage/SkPixelRef API Blink is no longer using pixel ref URIs to label lazy decoded images, so the URI-based heuristic is obsolete. Instead, use new SkPixelRef/SkImage isLazyGenerated() method. Also add missing drawImage & drawImageRect overrides + unit tests (similar to their drawBitmap, drawBitmapRect counterparts). BUG=skia:4224 R=reed@google.com,robertphillips@google.com CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/73df5c7ea28af683ee3235c6bf34b50e3f9b77d9 Cr-Commit-Position: refs/heads/master@{#344818}

Patch Set 1 #

Patch Set 2 : update cc_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -69 lines) Patch
M cc/playback/display_list_raster_source_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/playback/display_list_recording_source_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/playback/picture_pile_impl_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/playback/pixel_ref_map_unittest.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M cc/playback/recording_source_unittest.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M cc/test/skia_common.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/skia_common.cc View 1 2 chunks +15 lines, -6 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 5 chunks +63 lines, -15 lines 0 comments Download
M skia/ext/pixel_ref_utils_unittest.cc View 1 7 chunks +174 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
f(malita)
5 years, 4 months ago (2015-08-20 20:55:46 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-08-20 20:58:25 UTC) #4
vmpstr
lgtm, thanks!
5 years, 4 months ago (2015-08-20 21:11:17 UTC) #5
f(malita)
On 2015/08/20 21:11:17, vmpstr wrote: > lgtm, thanks! Patch set #1 missed a bunch of ...
5 years, 4 months ago (2015-08-21 08:37:47 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-08-21 15:16:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294673006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294673006/20001
5 years, 4 months ago (2015-08-21 18:14:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 18:21:29 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:22:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73df5c7ea28af683ee3235c6bf34b50e3f9b77d9
Cr-Commit-Position: refs/heads/master@{#344818}

Powered by Google App Engine
This is Rietveld 408576698