chrome/browser/ssl/ssl_error_handler.h - Issue 1294673005: Disable Name Mismatch redirection for non-overridable SSL errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_handler.h

Issue 1294673005: Disable Name Mismatch redirection for non-overridable SSL errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unittest Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_error_handler.h

diff --git a/chrome/browser/ssl/ssl_error_handler.h b/chrome/browser/ssl/ssl_error_handler.h

index 025eb1bdfe4f3c674388fa049d6769c85468cb61..689873b2c6058c673035a1f0e176080a2883e9a3 100644

--- a/chrome/browser/ssl/ssl_error_handler.h

+++ b/chrome/browser/ssl/ssl_error_handler.h

@@ -104,6 +104,7 @@ class SSLErrorHandler : public content::WebContentsUserData<SSLErrorHandler>,

GURL* suggested_url) const;

virtual void CheckSuggestedUrl(const GURL& suggested_url);

virtual void NavigateToSuggestedURL(const GURL& suggested_url);

+ virtual bool IsOverridable();

meacer 2015/08/20 23:15:22 const method

meacer 2015/08/20 23:15:22 nit: Rename this to IsErrorOverridable()

Bhanu Dev 2015/08/21 00:52:16 Done.

// content::NotificationObserver:

void Observe(

« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_handler.cc » ('j') | chrome/browser/ssl/ssl_error_handler_unittest.cc » ('J')