Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2729)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.h

Issue 1294663003: Fix various issues from r343263. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.h b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
index 7e927282cc4f97884955bb3619459cd64a796b0d..e0875a3162b02688c6dbf099b31078f4b85d8003 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.h
@@ -337,7 +337,10 @@ class PrintPreviewHandler
// Called when the DOM Distiller determines whether or not this page can
// be distilled.
// |distillable|: Whether or not this page can be distilled.
- void HandleIsPageDistillableResult(bool distillable);
Lei Zhang 2015/08/14 05:44:35 nit: name it consistently with everything else.
+ void OnGotPageDistillableResult(bool distillable);
+
+ // Called if the DOM Distiller failed.
+ void OnDistillerFailed();
// Register/unregister from notifications of changes done to the GAIA
// cookie.
@@ -395,8 +398,8 @@ class PrintPreviewHandler
// notify the test if it was a successful save, only that it was attempted.
base::Closure pdf_file_saved_closure_;
- // A print preview that is responsible for rendering the page after
Lei Zhang 2015/08/14 05:44:36 A PrintPreviewDistiller != "a print preview"
- // being processed by the DOM Distiller.
+ // The class that is responsible for rendering the page after being processed
+ // by the DOM Distiller.
scoped_ptr<PrintPreviewDistiller> print_preview_distiller_;
base::WeakPtrFactory<PrintPreviewHandler> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698