Fix various issues from r343263.

chrome/browser/ui/webui/print_preview/print_preview_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
 
 class PrintPreviewDataService;
 class PrintPreviewHandler;
 struct PrintHostMsg_DidGetPreviewPageCount_Params;
 struct PrintHostMsg_RequestPrintPreview_Params;
 struct PrintHostMsg_SetOptionsFromDocument_Params;
 
 namespace base {
@@ skipping 136 matching lines @@
 
   static void SetDelegateForTesting(TestingDelegate* delegate);
 
   // Allows for tests to set a file path to print a PDF to. This also initiates
   // the printing without having to click a button on the print preview dialog.
   void SetSelectedFileForTesting(const base::FilePath& path);
 
   // Passes |closure| to PrintPreviewHandler::SetPdfSavedClosureForTesting().
   void SetPdfSavedClosureForTesting(const base::Closure& closure);
 
-  base::WeakPtr<PrintPreviewUI> GetWeakPtr();

[Lei Zhang, 2015/08/14 05:44:36]

You should not create a WeakPtrFactory and publicly hand out WeakPtrs. As seen
in the WeakPtrFactory comments. "This is helpful if you only need weak pointers
within the implementation of a class."

Instead, this class should have subclassed from 
SupportsWeakPtr, if you really needed WeakPtrs for PrintPreviewUI, but it turns
out you don't.

-
  private:
   friend class PrintPreviewHandlerTest;
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsCustom);
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest, StickyMarginsDefault);
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
                            StickyMarginsCustomThenDefault);
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
                            GetLastUsedMarginSettingsCustom);
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewHandlerTest,
                            GetLastUsedMarginSettingsDefault);
@@ skipping 21 matching lines @@
   // Indicates whether only the selection should be printed.
   bool print_selection_only_;
 
   // Store the initiator title, used for populating the print preview dialog
   // title.
   base::string16 initiator_title_;
 
   // Keeps track of whether OnClosePrintPreviewDialog() has been called or not.
   bool dialog_closed_;
 
-  base::WeakPtrFactory<PrintPreviewUI> weak_ptr_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewUI);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_