Move AutofillProfileSyncableService into the Autofill component.

Move AutofillProfileSyncableService into the Autofill component.

This change enables this code to be built on iOS and facilitates the eventual
componentization of //chrome-browser/sync. As with other Autofill unit
tests, componentization of the unit test will follow.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245351

[blundell, 2014-01-08 21:46:30]

https://codereview.chromium.org/129463002/diff/1/components/autofill/core/bro...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(left):

https://codereview.chromium.org/129463002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:55:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
Is it worth adding a public getter of the DB thread on AutofillWebDataService in
order to add a DCHECK to CreateForWebDataServiceAndBackend() that the method is
called on the AutofillWebDataService's DB thread?

[Ilya Sherman, 2014-01-08 21:58:50]

Please note that [ https://codereview.chromium.org/127403002/ ], which touches
some of these files, is about to land; so you'll need to rebase.

[Ilya Sherman, 2014-01-08 23:27:24]

Drive-by LGTM

https://codereview.chromium.org/129463002/diff/1/components/autofill/core/bro...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(left):

https://codereview.chromium.org/129463002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:55:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
On 2014/01/08 21:46:31, blundell wrote:
> Is it worth adding a public getter of the DB thread on AutofillWebDataService
in
> order to add a DCHECK to CreateForWebDataServiceAndBackend() that the method
is
> called on the AutofillWebDataService's DB thread?

Probably not.  This class doesn't actually care which thread it's on, except
insofar as it depends on the DB code, which does care, and it needs to be on the
same thread as that code.  But, really, that's something that the DB code itself
should DCHECK, rather than having DCHECKs all the way up the stack.

[Nicolas Zea, 2014-01-08 23:55:46]

sync LGTM

[Jói, 2014-01-09 10:37:42]

LGTM

[commit-bot: I haz the power, 2014-01-09 20:38:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/129463002/140001

[commit-bot: I haz the power, 2014-01-09 21:46:09]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2014-01-09 22:33:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/129463002/140001

[commit-bot: I haz the power, 2014-01-09 23:36:52]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[blundell, 2014-01-10 21:01:56]

+benm@ to verify that I'm taking the right approach for Android WebView (in
particular, see //components/autofill.gypi). Thanks!

[blundell, 2014-01-13 13:33:23]

+bulach@

Marcus, if you have a chance to take a look at this that would work too. Thanks!

[blundell, 2014-01-13 19:57:35]

benm@: I responded to Marcus' offline comments re: wanting to have inclusion of
autofill_profile_syncable_service.h be a build-time error on Android WebView.
Please take a look!

[blundell, 2014-01-13 20:59:06]

On 2014/01/13 19:57:35, blundell wrote:
> benm@: I responded to Marcus' offline comments re: wanting to have inclusion
of
> autofill_profile_syncable_service.h be a build-time error on Android WebView.
> Please take a look!

You can hold off on looking at this patch...it's flawed. Will send out a
revision.

[blundell, 2014-01-15 10:13:09]

Marcus, could you take another look? The changes relevant to our discussion are
in the gyp(i) files and autofill_profile_syncable_service.h. Thanks!

[bulach, 2014-01-15 12:38:21]

lgtm, thanks! but please hold off for either torne and benm, there may be more
subtleties about the webview build that they would be able to spot..

[blundell, 2014-01-16 17:51:48]

benm/torne: Friendly ping.

[Torne, 2014-01-16 18:31:48]

gyp changes LGTM

[commit-bot: I haz the power, 2014-01-16 19:55:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/129463002/610001

[commit-bot: I haz the power, 2014-01-16 22:19:18]

Change committed as 245351

[Andrew T Wilson (Slow), 2014-02-18 12:14:32]

sync lgtm