Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1294613002: Revert of SkScaledCodec class (Closed)

Created:
5 years, 4 months ago by emmaleer
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkScaledCodec class (patchset #34 id:660001 of https://codereview.chromium.org/1260673002/ ) Reason for revert: Seg-faulting: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Release/builds/1608/steps/dm/logs/stdio Original issue's description: > SkScaledCodec class > > This class does scaling by using a scanlineDecoder. > getScanlines and skipScanlines are used for y sampling, > the swizzler is used for x sampling > > this class is currently only working for png and jpeg images > I will update other Codec types to work soon > > For SkJpegCodec to implement width wise swizzling it now > uses a swizzler. I ran performance tests on this change. > Here are the performance test results: > https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/0944100ac89f797714eeae0cf2875e2335ff52ee > > Committed: https://skia.googlesource.com/skia/+/d518ea7927f9f4e0ed5b4134d1b4f48243855a47 TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c7993d747fff40328b6666845761efbbbfe720b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -805 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M dm/DMSrcSink.cpp View 3 chunks +9 lines, -17 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/codec/SkCodec.h View 1 chunk +0 lines, -2 lines 0 comments Download
D include/codec/SkScaledCodec.h View 1 chunk +0 lines, -70 lines 0 comments Download
M include/codec/SkScanlineDecoder.h View 2 chunks +0 lines, -42 lines 0 comments Download
M src/codec/SkBmpStandardCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkCodec_libgif.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/codec/SkCodec_libpng.h View 2 chunks +1 line, -1 line 0 comments Download
M src/codec/SkCodec_libpng.cpp View 9 chunks +8 lines, -25 lines 0 comments Download
M src/codec/SkCodec_wbmp.cpp View 4 chunks +4 lines, -11 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +10 lines, -4 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 12 chunks +19 lines, -102 lines 0 comments Download
D src/codec/SkScaledCodec.cpp View 1 chunk +0 lines, -261 lines 0 comments Download
M src/codec/SkSwizzler.h View 3 chunks +10 lines, -19 lines 0 comments Download
M src/codec/SkSwizzler.cpp View 21 chunks +187 lines, -240 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
emmaleer
Created Revert of SkScaledCodec class
5 years, 4 months ago (2015-08-13 20:25:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294613002/1
5 years, 4 months ago (2015-08-13 20:25:45 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-13 20:25:46 UTC) #3
scroggo
On 2015/08/13 20:25:46, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 4 months ago (2015-08-13 20:58:38 UTC) #4
scroggo
On 2015/08/13 20:58:38, scroggo wrote: > On 2015/08/13 20:25:46, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-13 20:58:45 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 20:59:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7993d747fff40328b6666845761efbbbfe720b7

Powered by Google App Engine
This is Rietveld 408576698