net/android/java/src/org/chromium/net/NetworkChangeNotifier.java - Issue 1294603003: [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/java/src/org/chromium/net/NetworkChangeNotifier.java

Issue 1294603003: [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (Post-Blink-Chromium-Merge) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java ('K') | « content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java ('k') | testing/android/native_test/java/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/android/java/src/org/chromium/net/NetworkChangeNotifier.java

diff --git a/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java b/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java

index 563ef5c0d2cda697938fedf3371f573a51ffa5ba..f76a27096057a920c85964958325bc56a2a65554 100644

--- a/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java

+++ b/net/android/java/src/org/chromium/net/NetworkChangeNotifier.java

@@ -81,7 +81,13 @@ public class NetworkChangeNotifier {

* Calls a native map lookup of subtype to max bandwidth.

public static double getMaxBandwidthForConnectionSubtype(int subtype) {

- return nativeGetMaxBandwidthForConnectionSubtype(subtype);

+ // This may fail in unit tests, if the JNI native methods have not been registered.

jkarlin 2015/09/24 17:51:30 Ditto

iclelland 2015/09/24 20:37:20 Acknowledged.

+ try {

+ return nativeGetMaxBandwidthForConnectionSubtype(subtype);

+ } catch (UnsatisfiedLinkError e) {

+ // Return an arbitrary value for unit tests

+ return 0.0;

+ }

}

/**