content/browser/background_sync/background_sync_manager.cc - Issue 1294603003: [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1294603003: [BackgroundSync] Trigger Background Sync events when Chrome is backgrounded on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update browser tests to trigger network observer directly Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/background_sync/background_sync_browsertest.cc ('K') | « content/browser/background_sync/background_sync_manager.h ('k') | content/browser/background_sync/background_sync_network_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index 6ba38b57924d1e0dbe2ded9e8775ea56e176531d..c3db1373f33861bd240fabec0c4df694e7f1875a 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -19,6 +19,7 @@

#if defined(OS_ANDROID)

#include "content/browser/android/background_sync_launcher_android.h"

+#include "content/browser/android/background_sync_network_observer_android.h"

#endif

namespace {

@@ -197,9 +198,15 @@ BackgroundSyncManager::BackgroundSyncManager(

service_worker_context_->AddObserver(this);

+#if defined(OS_ANDROID)

+ network_observer_.reset(new BackgroundSyncNetworkObserverAndroid(

+ base::Bind(&BackgroundSyncManager::OnNetworkChanged,

+ weak_ptr_factory_.GetWeakPtr())));

+#else

network_observer_.reset(new BackgroundSyncNetworkObserver(

base::Bind(&BackgroundSyncManager::OnNetworkChanged,

weak_ptr_factory_.GetWeakPtr())));

+#endif

power_observer_.reset(new BackgroundSyncPowerObserver(base::Bind(

&BackgroundSyncManager::OnPowerChanged, weak_ptr_factory_.GetWeakPtr())));

}