Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1294603002: Add run-webkit-tests support and generate baselines for win8 and win10. (Closed)

Created:
5 years, 4 months ago by joelo
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, jsbell, ojan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add run-webkit-tests support and generate baselines for win8 and win10. This changes the following: * win10 is now the primary win port version. * win7 baselines are placed in win7/ instead of win/ * Baseline directory search path is now xp -> win7 -> win8 -> win BUG=496259 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200611

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove 64 bit versions references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -17 lines) Patch
M Tools/Scripts/webkitpy/common/system/platforminfo.py View 1 chunk +11 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +15 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/builders.py View 2 chunks +4 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win.py View 2 chunks +9 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 chunk +34 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
joelo
ptal :) To avoid breaking auto-rebaselining this needs to wait for the new builders to ...
5 years, 4 months ago (2015-08-13 19:53:44 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1294603002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py File Tools/Scripts/webkitpy/layout_tests/port/base.py (right): https://codereview.chromium.org/1294603002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py#newcode109 Tools/Scripts/webkitpy/layout_tests/port/base.py:109: ('win8', 'x86_64'), are we supporting both 32-bit and 64-bit ...
5 years, 4 months ago (2015-08-13 20:08:35 UTC) #3
joelo
ptal https://codereview.chromium.org/1294603002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py File Tools/Scripts/webkitpy/layout_tests/port/base.py (right): https://codereview.chromium.org/1294603002/diff/1/Tools/Scripts/webkitpy/layout_tests/port/base.py#newcode109 Tools/Scripts/webkitpy/layout_tests/port/base.py:109: ('win8', 'x86_64'), On 2015/08/13 20:08:35, Dirk Pranke wrote: ...
5 years, 4 months ago (2015-08-13 20:46:13 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-13 20:47:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294603002/20001
5 years, 4 months ago (2015-08-14 20:29:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93553)
5 years, 4 months ago (2015-08-14 21:48:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294603002/20001
5 years, 4 months ago (2015-08-15 17:16:06 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 17:56:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200611

Powered by Google App Engine
This is Rietveld 408576698