Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294583006: Clean up native context slots and add new ones. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up native context slots and add new ones. Newly added native context slots are used to avoid accessing the js builtins object to get native functions. R=jkummerow@chromium.org Committed: https://crrev.com/e4c286900e29647f5ac3cd49d63d06bbfb98d078 Cr-Commit-Position: refs/heads/master@{#30181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -268 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 2 chunks +36 lines, -46 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +27 lines, -7 lines 0 comments Download
M src/contexts.h View 6 chunks +21 lines, -142 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/json.js View 2 chunks +5 lines, -3 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/math.js View 3 chunks +4 lines, -13 lines 0 comments Download
M src/messages.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/messages.js View 3 chunks +9 lines, -19 lines 0 comments Download
M src/prologue.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/promise.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-14 14:06:55 UTC) #1
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-14 14:43:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294583006/1
5 years, 4 months ago (2015-08-14 14:46:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 15:12:40 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 15:13:01 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e4c286900e29647f5ac3cd49d63d06bbfb98d078
Cr-Commit-Position: refs/heads/master@{#30181}

Powered by Google App Engine
This is Rietveld 408576698