Allowing optional build of a WASM prototype behind a gyp define.

Allowing optional build of a WASM prototype behind a gyp define.

Place a copy of the v8-native-prototype in third_party/wasm.
GYP_DEFINES='v8_wasm=1' gclient runhooks

BUG=None
TEST=None
R=titzer@chromium.org
LOG=N

Committed: https://crrev.com/a2462683b704e943862bbe90ddc26c2c24a74e97
Cr-Commit-Position: refs/heads/master@{#30225}

[bradn, 2015-08-17 18:02:52]

Patchset #1 (id:1) has been deleted

[bradn, 2015-08-17 18:03:00]

Patchset #1 (id:20001) has been deleted

[bradn, 2015-08-17 18:04:12]

Patchset #1 (id:40001) has been deleted

[bradn, 2015-08-17 18:17:11]

Patchset #1 (id:60001) has been deleted

[bradn, 2015-08-18 03:36:41]

Patchset #3 (id:120001) has been deleted

[titzer, 2015-08-18 09:01:11]

On 2015/08/17 18:18:35, bradn wrote:

Looks good from my side, adding mstarzinger@ who wields better GYP-fu.

[titzer, 2015-08-18 09:01:25]

titzer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-08-18 14:20:40]

mstarzinger@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Michael Starzinger, 2015-08-18 14:20:40]

Looks good, just one comment. But I am not wielding GYP-foo at all. Maybe
jkummerow@ can glance over the GYP changes.

https://codereview.chromium.org/1294543006/diff/130001/DEPS
File DEPS (right):

https://codereview.chromium.org/1294543006/diff/130001/DEPS#newcode15
DEPS:15: "v8/third_party/wasm":
Can we for now not pull this dependency? People working on WebAssembly in V8
would need to setup a this dependency (or some sort of symlink) themselves for
now, but the rest of the build-system is ready to build the WebAssembly
prototype without changes. WDYT?

[Michael Starzinger, 2015-08-18 14:26:30]

LGTM from my end modulo the comment in DEPS.

[bradn, 2015-08-18 14:42:44]

https://codereview.chromium.org/1294543006/diff/130001/DEPS
File DEPS (right):

https://codereview.chromium.org/1294543006/diff/130001/DEPS#newcode15
DEPS:15: "v8/third_party/wasm":
On 2015/08/18 14:20:40, Michael Starzinger wrote:
> Can we for now not pull this dependency? People working on WebAssembly in V8
> would need to setup a this dependency (or some sort of symlink) themselves for
> now, but the rest of the build-system is ready to build the WebAssembly
> prototype without changes. WDYT?

Yep, make sense.
Done.

[Jakob Kummerow, 2015-08-18 14:52:02]

lgtm

[bradn, 2015-08-18 14:52:49]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-08-18 14:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1294543006/#ps150001
(title: "drop deps")

[commit-bot: I haz the power, 2015-08-18 14:52:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294543006/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294543006/150001

[commit-bot: I haz the power, 2015-08-18 15:04:07]

Committed patchset #4 (id:150001)

[commit-bot: I haz the power, 2015-08-18 15:04:23]

Patchset 4 (id:??) landed as
https://crrev.com/a2462683b704e943862bbe90ddc26c2c24a74e97
Cr-Commit-Position: refs/heads/master@{#30225}