Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1294543005: Move execCommand related files in core/editing/ related files into core/editing/commands/ (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, brucedawson
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, dcheng, groby+blinkspell_chromium.org, kinuko+watch, Nate Chapin, gavinp+loader_chromium.org, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move execCommand related files in core/editing/ related files into core/editing/commands/ This patch moves spell checker related files into "core/editing/commands/" directory to reduce number of files immediately under "core/editing/" for ease of working these files as same as issue 448772, which moves iterator related files into "core/editing/iterators/". Moved files: - *Command.{cpp,h} - EditAction.h - SmartReplace.h - SmartReplaceCF.h - SmartReplaceICU.h - UndoStack.{cpp,h} - UndoStep.{cpp,h} This patch also arrange order of editing files in "core.gypi" to match with C++ files. BUG=509527 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200713

Patch Set 1 : 2015-08-17T17:57:33 #

Total comments: 3

Patch Set 2 : 2015-08-18T14:20:58 Rebase for merging code style fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -15225 lines) Patch
M Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 3 chunks +93 lines, -83 lines 1 comment Download
D Source/core/editing/AppendNodeCommand.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/editing/AppendNodeCommand.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/editing/ApplyBlockElementCommand.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/editing/ApplyBlockElementCommand.cpp View 1 1 chunk +0 lines, -299 lines 0 comments Download
D Source/core/editing/ApplyStyleCommand.h View 1 1 chunk +0 lines, -144 lines 0 comments Download
D Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +0 lines, -1603 lines 0 comments Download
D Source/core/editing/BreakBlockquoteCommand.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/editing/BreakBlockquoteCommand.cpp View 1 1 chunk +0 lines, -221 lines 0 comments Download
D Source/core/editing/CompositeEditCommand.h View 1 chunk +0 lines, -182 lines 0 comments Download
D Source/core/editing/CompositeEditCommand.cpp View 1 1 chunk +0 lines, -1511 lines 0 comments Download
D Source/core/editing/CreateLinkCommand.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/editing/CreateLinkCommand.cpp View 1 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/editing/DeleteFromTextNodeCommand.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/core/editing/DeleteSelectionCommand.h View 1 chunk +0 lines, -105 lines 0 comments Download
D Source/core/editing/DeleteSelectionCommand.cpp View 1 1 chunk +0 lines, -906 lines 0 comments Download
D Source/core/editing/EditAction.h View 1 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/editing/EditCommand.h View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/editing/EditCommand.cpp View 1 chunk +0 lines, -116 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
D Source/core/editing/EditorCommand.cpp View 1 1 chunk +0 lines, -1800 lines 0 comments Download
D Source/core/editing/FormatBlockCommand.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/editing/FormatBlockCommand.cpp View 1 chunk +0 lines, -177 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/editing/IndentOutdentCommand.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +0 lines, -258 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/editing/InsertIntoTextNodeCommand.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/core/editing/InsertLineBreakCommand.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/editing/InsertLineBreakCommand.cpp View 1 1 chunk +0 lines, -166 lines 0 comments Download
D Source/core/editing/InsertListCommand.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/editing/InsertListCommand.cpp View 1 1 chunk +0 lines, -429 lines 0 comments Download
D Source/core/editing/InsertNodeBeforeCommand.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/editing/InsertParagraphSeparatorCommand.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 1 chunk +0 lines, -440 lines 0 comments Download
D Source/core/editing/InsertTextCommand.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/core/editing/InsertTextCommand.cpp View 1 1 chunk +0 lines, -273 lines 0 comments Download
D Source/core/editing/MergeIdenticalElementsCommand.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/editing/MoveSelectionCommand.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/editing/MoveSelectionCommand.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/editing/RemoveCSSPropertyCommand.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/editing/RemoveFormatCommand.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/editing/RemoveFormatCommand.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/editing/RemoveNodeCommand.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/editing/RemoveNodeCommand.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/editing/RemoveNodePreservingChildrenCommand.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/editing/RemoveNodePreservingChildrenCommand.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/editing/ReplaceNodeWithSpanCommand.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/editing/ReplaceSelectionCommand.h View 1 chunk +0 lines, -124 lines 0 comments Download
D Source/core/editing/ReplaceSelectionCommand.cpp View 1 1 chunk +0 lines, -1558 lines 0 comments Download
D Source/core/editing/SetNodeAttributeCommand.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/editing/SetNodeAttributeCommand.cpp View 1 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/editing/SimplifyMarkupCommand.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
D Source/core/editing/SmartReplace.h View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/editing/SmartReplaceCF.cpp View 1 1 chunk +0 lines, -73 lines 0 comments Download
D Source/core/editing/SmartReplaceICU.cpp View 1 1 chunk +0 lines, -99 lines 0 comments Download
D Source/core/editing/SplitElementCommand.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/editing/SplitElementCommand.cpp View 1 chunk +0 lines, -116 lines 0 comments Download
D Source/core/editing/SplitTextNodeCommand.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/editing/SplitTextNodeCommand.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
D Source/core/editing/SplitTextNodeContainingElementCommand.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/editing/SplitTextNodeContainingElementCommand.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/editing/TextInsertionBaseCommand.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/editing/TextInsertionBaseCommand.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/core/editing/TypingCommand.h View 1 chunk +0 lines, -138 lines 0 comments Download
D Source/core/editing/TypingCommand.cpp View 1 chunk +0 lines, -635 lines 0 comments Download
D Source/core/editing/UndoStack.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/editing/UndoStack.cpp View 1 chunk +0 lines, -129 lines 0 comments Download
D Source/core/editing/UndoStep.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/editing/UnlinkCommand.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/editing/UnlinkCommand.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/editing/WrapContentsInDummySpanCommand.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/editing/WrapContentsInDummySpanCommand.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
A + Source/core/editing/commands/AppendNodeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/AppendNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ApplyBlockElementCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ApplyStyleCommand.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/BreakBlockquoteCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/CompositeEditCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 chunks +20 lines, -20 lines 0 comments Download
A + Source/core/editing/commands/CreateLinkCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/CreateLinkCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/DeleteFromTextNodeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/DeleteSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/EditAction.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/commands/EditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/EditCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/EditorCommand.cpp View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + Source/core/editing/commands/FormatBlockCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/IndentOutdentCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/InsertIntoTextNodeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertLineBreakCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertListCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertListCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertNodeBeforeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertNodeBeforeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertParagraphSeparatorCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/InsertTextCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/InsertTextCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/MergeIdenticalElementsCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/MergeIdenticalElementsCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/MoveSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/MoveSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/RemoveCSSPropertyCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveCSSPropertyCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveFormatCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveFormatCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/RemoveNodeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveNodePreservingChildrenCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/RemoveNodePreservingChildrenCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ReplaceNodeWithSpanCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ReplaceSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + Source/core/editing/commands/SetNodeAttributeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SetNodeAttributeCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SimplifyMarkupCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SmartReplace.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/commands/SmartReplaceCF.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SmartReplaceICU.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitElementCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitTextNodeCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitTextNodeContainingElementCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/TextInsertionBaseCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/TextInsertionBaseCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/TypingCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/TypingCommand.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + Source/core/editing/commands/UndoStack.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/commands/UndoStack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/commands/UndoStep.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/UnlinkCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/UnlinkCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/WrapContentsInDummySpanCommand.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-17 09:26:49 UTC) #2
tkent
Please do not fix coding style in this CL. It requires extra review time, and ...
5 years, 4 months ago (2015-08-17 09:58:11 UTC) #3
yosin_UTC9
PTAL https://codereview.chromium.org/1294543005/diff/1/Source/core/core.gypi File Source/core/core.gypi (right): https://codereview.chromium.org/1294543005/diff/1/Source/core/core.gypi#newcode1371 Source/core/core.gypi:1371: 'editing/commands/SmartReplace.hp', On 2015/08/17 09:58:11, tkent wrote: > SmartReplace.hp ...
5 years, 4 months ago (2015-08-18 05:58:44 UTC) #6
tkent
lgtm
5 years, 4 months ago (2015-08-18 06:53:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294543005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294543005/60001
5 years, 4 months ago (2015-08-18 06:55:50 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200713
5 years, 4 months ago (2015-08-18 07:56:46 UTC) #10
brucedawson
https://codereview.chromium.org/1294543005/diff/60001/Source/core/core.gypi File Source/core/core.gypi (right): https://codereview.chromium.org/1294543005/diff/60001/Source/core/core.gypi#newcode1336 Source/core/core.gypi:1336: 'editing/commands/EditorCommand.h', The file EditorCommand.h does not exist. This line ...
5 years, 4 months ago (2015-08-24 17:22:00 UTC) #12
yosin_UTC9
5 years, 4 months ago (2015-08-25 00:47:37 UTC) #13
Message was sent while issue was closed.
On 2015/08/24 at 17:22:00, brucedawson wrote:
> https://codereview.chromium.org/1294543005/diff/60001/Source/core/core.gypi
> File Source/core/core.gypi (right):
> 
>
https://codereview.chromium.org/1294543005/diff/60001/Source/core/core.gypi#n...
> Source/core/core.gypi:1336: 'editing/commands/EditorCommand.h',
> The file EditorCommand.h does not exist. This line should be removed from
core.gypi.

Oops, good catch.
Removing... http://crrev.com/1312003002

Powered by Google App Engine
This is Rietveld 408576698