src/runtime/runtime-compiler.cc - Issue 1294543002: [Interpreter] Minimal bytecode generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-compiler.cc

Issue 1294543002: [Interpreter] Minimal bytecode generator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-register-conversion

Patch Set: Incorporate review comments on patch sets 2 & 3. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-compiler.cc

diff --git a/src/runtime/runtime-compiler.cc b/src/runtime/runtime-compiler.cc

index a60252717573be68b9cc9b8d9d535863da0aeea4..13b54cc60086a2760e61bba0ed73f7cd5a4fa58c 100644

--- a/src/runtime/runtime-compiler.cc

+++ b/src/runtime/runtime-compiler.cc

@@ -35,8 +35,8 @@ RUNTIME_FUNCTION(Runtime_CompileLazy) {

Handle<Code> code;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, code,

Compiler::GetLazyCode(function));

- DCHECK(code->kind() == Code::FUNCTION ||

- code->kind() == Code::OPTIMIZED_FUNCTION);

+ DCHECK(code->IsJavaScriptCode());

function->ReplaceCode(*code);

return *code;

}

« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »