src/interpreter/bytecode-array-builder.cc - Issue 1294543002: [Interpreter] Minimal bytecode generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1294543002: [Interpreter] Minimal bytecode generator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-register-conversion

Patch Set: Incorporate review comments on patch sets 2 & 3. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-array-builder.cc

diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc

index 8cc0772db97d4b0a98180c57d5c0ffa28d8cc726..24fec96bfa47bd0a76feaea9ce815f6b458f0282 100644

--- a/src/interpreter/bytecode-array-builder.cc

+++ b/src/interpreter/bytecode-array-builder.cc

@@ -50,7 +50,7 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::LoadLiteral(

int32_t raw_smi = smi->value();

if (raw_smi == 0) {

Output(Bytecode::kLdaZero);

- } else if (raw_smi > -128 && raw_smi <= 128) {

+ } else if (raw_smi >= -128 && raw_smi <= 127) {

Output(Bytecode::kLdaSmi8, static_cast<uint8_t>(raw_smi));

} else {

// TODO(oth): Put Smi in constant pool.

« no previous file with comments | « src/flag-definitions.h ('k') | src/interpreter/bytecode-generator.h » ('j') | no next file with comments »