Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/runtime/runtime-compiler.cc

Issue 1294543002: [Interpreter] Minimal bytecode generator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-register-conversion
Patch Set: Incorporate comments on patch set 1 and add a simple test. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-compiler.cc
diff --git a/src/runtime/runtime-compiler.cc b/src/runtime/runtime-compiler.cc
index a60252717573be68b9cc9b8d9d535863da0aeea4..a8de13136ab6078a034b4d02abb0a3a0626508c8 100644
--- a/src/runtime/runtime-compiler.cc
+++ b/src/runtime/runtime-compiler.cc
@@ -35,8 +35,11 @@ RUNTIME_FUNCTION(Runtime_CompileLazy) {
Handle<Code> code;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, code,
Compiler::GetLazyCode(function));
- DCHECK(code->kind() == Code::FUNCTION ||
- code->kind() == Code::OPTIMIZED_FUNCTION);
+ DCHECK(
+ code->kind() == Code::FUNCTION ||
Michael Starzinger 2015/08/18 08:17:16 suggestion: Do you think it makes sense to add a C
+ code->kind() == Code::OPTIMIZED_FUNCTION ||
+ code.is_identical_to(isolate->builtins()->InterpreterEntryTrampoline()));
+
function->ReplaceCode(*code);
return *code;
}

Powered by Google App Engine
This is Rietveld 408576698