ozone: Handle pressure and tilt for stylus devices

ozone: Handle pressure and tilt for stylus devices

With the enablement of the W3C Pointer Events specification it is now possible
to interpret evdev events for pressure and tilt and expose them through the
ui::MouseEvent's PointerDetails. We can also now expose that this mouse event
is really from a pen type device.

In order to work better with the Ozone input layer the method to set the
PointerDetails for MouseEvent were changed to accept a complete PointerDetails
object rather than per member mutators.

BUG=516706
TEST=TabletEventConverterTest enhanced to look at tilt and pressure values,
interactive testing on link with stylus device show it continues to behave as
expected.

Committed: https://crrev.com/953aa1bd2eef603489045f760a9c35ce50aa7c4f
Cr-Commit-Position: refs/heads/master@{#345049}

[robert.bradford, 2015-08-17 11:41:27]

robert.bradford@intel.com changed reviewers:
+ sadrul@chromium.org, spang@chromium.org

[robert.bradford, 2015-08-17 11:41:27]

Hi spang@ & sadrul@ here is what the Ozone patch to enable the advanced stylus
features (as part of the Pointer Events enabling) looks like.

[spang, 2015-08-18 21:56:06]

On 2015/08/17 11:41:27, robert.bradford wrote:
> Hi spang@ & sadrul@ here is what the Ozone patch to enable the advanced stylus
> features (as part of the Pointer Events enabling) looks like.

where's the rest of it? please state any patch dependencies when sending it out

[spang, 2015-08-18 21:56:44]

On 2015/08/18 21:56:06, spang wrote:
> On 2015/08/17 11:41:27, robert.bradford wrote:
> > Hi spang@ & sadrul@ here is what the Ozone patch to enable the advanced
stylus
> > features (as part of the Pointer Events enabling) looks like.
> 
> where's the rest of it? please state any patch dependencies when sending it
out

Oh, shoot, I see it in the UI now. Neat.

[spang, 2015-08-18 22:17:45]

https://codereview.chromium.org/1294523004/diff/20001/ui/events/ozone/evdev/t...
File ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc (right):

https://codereview.chromium.org/1294523004/diff/20001/ui/events/ozone/evdev/t...
ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc:426:
EXPECT_EQ((90.0f * 68) / 127, event->pointer_details().tilt_x());
Use EXPECT_FLOAT_EQ for this.

[robert.bradford, 2015-08-19 17:57:34]

Yeh, the new CL dependencies feature is not super visible unless you know what
you're looking for but it's pretty cool and the CQ will enforce deps and also
tryjobs do the right thing.

https://codereview.chromium.org/1294523004/diff/20001/ui/events/ozone/evdev/t...
File ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc (right):

https://codereview.chromium.org/1294523004/diff/20001/ui/events/ozone/evdev/t...
ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc:426:
EXPECT_EQ((90.0f * 68) / 127, event->pointer_details().tilt_x());
On 2015/08/18 22:17:45, spang wrote:
> Use EXPECT_FLOAT_EQ for this.

Done.

[spang, 2015-08-19 18:14:58]

lgtm

[sadrul, 2015-08-20 06:25:50]

https://codereview.chromium.org/1294523004/diff/40001/ui/events/ozone/evdev/d...
File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right):

https://codereview.chromium.org/1294523004/diff/40001/ui/events/ozone/evdev/d...
ui/events/ozone/evdev/device_event_dispatcher_evdev.h:54: float tilt_y;
Is there a reason to not use PointerDetails for these?

[robert.bradford, 2015-08-20 11:12:28]

https://codereview.chromium.org/1294523004/diff/40001/ui/events/ozone/evdev/d...
File ui/events/ozone/evdev/device_event_dispatcher_evdev.h (right):

https://codereview.chromium.org/1294523004/diff/40001/ui/events/ozone/evdev/d...
ui/events/ozone/evdev/device_event_dispatcher_evdev.h:54: float tilt_y;
On 2015/08/20 06:25:50, sadrul wrote:
> Is there a reason to not use PointerDetails for these?

That's a great suggestion and i've implemented it. As I was doing it it occurred
to me we could just update the PointerDetails in the mouse event which makes
this change even neater.

As such I added a new mutator to ui::MouseEvent and would like your review of
that as OWNER.

[sadrul, 2015-08-21 19:32:22]

lgtm

https://codereview.chromium.org/1294523004/diff/60001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/1294523004/diff/60001/ui/events/event.h#newco...
ui/events/event.h:477: void set_radius_y(const float r) {
pointer_details_.radius_y_ = r; }
These can now go?

[robert.bradford, 2015-08-24 10:57:46]

On 2015/08/21 19:32:22, sadrul wrote:
> lgtm
> 
> https://codereview.chromium.org/1294523004/diff/60001/ui/events/event.h
> File ui/events/event.h (right):
> 
>
https://codereview.chromium.org/1294523004/diff/60001/ui/events/event.h#newco...
> ui/events/event.h:477: void set_radius_y(const float r) {
> pointer_details_.radius_y_ = r; }
> These can now go?

Yes, this looks much nicer. Updated patch uploaded.

[robert.bradford, 2015-08-24 11:02:14]

The CQ bit was checked by robert.bradford@intel.com

[robert.bradford, 2015-08-24 11:02:14]

The patchset sent to the CQ was uploaded after l-g-t-m from spang@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1294523004/#ps80001
(title: "Drop now unused mutators.")

[commit-bot: I haz the power, 2015-08-24 11:02:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294523004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294523004/80001

[commit-bot: I haz the power, 2015-08-24 11:48:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-24 11:48:59]

Patchset 5 (id:??) landed as
https://crrev.com/953aa1bd2eef603489045f760a9c35ce50aa7c4f
Cr-Commit-Position: refs/heads/master@{#345049}