Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294523002: [Interpreter] Register conversion fix and test. (Closed)

Created:
5 years, 4 months ago by oth
Modified:
5 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Register conversion fix and test. BUG=v8:4280 LOG=N Committed: https://crrev.com/93f906d89e037860b7e00971048f37c6f9719947 Cr-Commit-Position: refs/heads/master@{#30163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1294543002 Patch 1

Messages

Total messages: 7 (2 generated)
oth
Ross, PTAL, thanks!
5 years, 4 months ago (2015-08-13 15:54:24 UTC) #2
rmcilroy
On 2015/08/13 15:54:24, oth wrote: > Ross, PTAL, thanks! lgtm, thanks for the fix!
5 years, 4 months ago (2015-08-13 16:32:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294523002/1
5 years, 4 months ago (2015-08-13 16:39:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 17:11:30 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 17:11:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/93f906d89e037860b7e00971048f37c6f9719947
Cr-Commit-Position: refs/heads/master@{#30163}

Powered by Google App Engine
This is Rietveld 408576698