chrome/browser/ui/extensions/shell_window.cc - Issue 12945007: Fix Notifications Icon loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/shell_window.cc

diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc

index ade284ac01765dc9b3b300e66f1b4c9b9f007877..b0efa69e94a6d48392ff7f29ff4165c96475ced5 100644

--- a/chrome/browser/ui/extensions/shell_window.cc

+++ b/chrome/browser/ui/extensions/shell_window.cc

@@ -358,7 +358,9 @@ string16 ShellWindow::GetTitle() const {

void ShellWindow::SetAppIconUrl(const GURL& url) {

app_icon_url_ = url;

- web_contents()->DownloadFavicon(url, kPreferredIconSize,

+ web_contents()->DownloadFavicon(url,

+ true,

+ kPreferredIconSize,

base::Bind(&ShellWindow::DidDownloadFavicon,

weak_ptr_factory_.GetWeakPtr()));

}