Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7528)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tiny fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('K') | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('j') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index ade284ac01765dc9b3b300e66f1b4c9b9f007877..2a64888f8a0a27a08daccd2ad2d2b86b1b0dcd35 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -358,7 +358,9 @@ string16 ShellWindow::GetTitle() const {
void ShellWindow::SetAppIconUrl(const GURL& url) {
app_icon_url_ = url;
- web_contents()->DownloadFavicon(url, kPreferredIconSize,
+ web_contents()->DownloadFavicon(url,
+ true, // favicon
jam 2013/03/20 02:44:42 ditto
+ kPreferredIconSize,
base::Bind(&ShellWindow::DidDownloadFavicon,
weak_ptr_factory_.GetWeakPtr()));
}
« chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('K') | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('j') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698