Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294483002: [Line Layout API] Convert InlineBox::boxModelObject to new API (Closed)

Created:
5 years, 4 months ago by pilgrim_google
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, ikilpatrick, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Line Layout API] Convert InlineBox::boxModelObject to new API The function in question now returns a LineLayoutBoxModel instead of a LayoutBoxModelObject*. To keep the CL size down, I've also added a deprecatedBoxModelObject() method which still returns a LayoutBoxModelObject*, because there are several references in core/paint/InlineFlowBoxPainter.cpp that take the returned object and pass it around and call a bunch of methods that aren't part of the line layout API yet. I will tackle those in a followup patch. BUG=499321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200647

Patch Set 1 #

Patch Set 2 : progress but still doesn't compile #

Patch Set 3 : add deprecatedBoxModelObject method for things I'm not willing to fix yet #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -60 lines) Patch
M Source/core/layout/LayoutListItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/api/LineLayoutBoxModel.h View 1 1 chunk +92 lines, -2 lines 0 comments Download
M Source/core/layout/api/LineLayoutItem.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 1 2 3 4 3 chunks +12 lines, -3 lines 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 3 chunks +25 lines, -25 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 2 10 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
5 years, 4 months ago (2015-08-14 14:04:14 UTC) #1
pilgrim_google
5 years, 4 months ago (2015-08-14 14:04:31 UTC) #3
leviw_travelin_and_unemployed
LGTM. Please wrap the cl description to 80 characters. https://codereview.chromium.org/1294483002/diff/60001/Source/core/layout/line/InlineBox.h File Source/core/layout/line/InlineBox.h (right): https://codereview.chromium.org/1294483002/diff/60001/Source/core/layout/line/InlineBox.h#newcode274 Source/core/layout/line/InlineBox.h:274: ...
5 years, 4 months ago (2015-08-14 22:28:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294483002/80001
5 years, 4 months ago (2015-08-17 13:10:09 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 15:59:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200647

Powered by Google App Engine
This is Rietveld 408576698