Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294473008: Makes OOPIFs the default (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes OOPIFs the default I'll nuke the old code path soonish. BUG=479172, 490221 TEST=none R=fsamuel@chromium.org Committed: https://crrev.com/fb43a586c8e1503533438af9a5a3a4722efae155 Cr-Commit-Position: refs/heads/master@{#343512}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 1 chunk +5 lines, -1 line 1 comment Download
M components/html_viewer/html_frame_apptest.cc View 2 chunks +4 lines, -2 lines 1 comment Download
M components/html_viewer/html_viewer_switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_viewer_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/data/apptests View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
5 years, 4 months ago (2015-08-14 20:58:10 UTC) #1
Fady Samuel
LGTM + couple of nits: Can you use simpler expressions? https://codereview.chromium.org/1294473008/diff/20001/components/html_viewer/html_document_application_delegate.cc File components/html_viewer/html_document_application_delegate.cc (right): https://codereview.chromium.org/1294473008/diff/20001/components/html_viewer/html_document_application_delegate.cc#newcode24 ...
5 years, 4 months ago (2015-08-14 21:32:36 UTC) #2
sky
On 2015/08/14 21:32:36, Fady Samuel wrote: > LGTM + couple of nits: Can you use ...
5 years, 4 months ago (2015-08-14 21:42:19 UTC) #3
sky
5 years, 4 months ago (2015-08-14 21:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294473008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294473008/20001
5 years, 4 months ago (2015-08-14 21:43:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 22:24:16 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 22:24:52 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fb43a586c8e1503533438af9a5a3a4722efae155
Cr-Commit-Position: refs/heads/master@{#343512}

Powered by Google App Engine
This is Rietveld 408576698