Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 23a5fdc465cedddf752a08c0dc952a38c72d9a60..4a7fdf5b9c6ef4cc8a88c149ebe2dde4bb1c1143 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -2713,6 +2713,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <owner>jyasskin@chromium.org</owner> |
| <owner>ortuno@chromium.org</owner> |
| <owner>scheib@chromium.org</owner> |
| + <obsolete> |
| + As of 08/2015 this has been replaced by |
| + Bluetooth.Web.Characteristic.ReadValue and |
| + Bluetooth.Web.Characteristic.WriteValue. |
| + </obsolete> |
| <summary> |
| Records how many times each GATT Error has occured. The results will be used |
| to determine how common this errors are and if we need to provide better |
| @@ -2752,6 +2757,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Bluetooth.Web.Characteristic.ReadValue.Outcome" |
| + enum="WebBluetoothGATTOperationOutcome"> |
| + <owner>jyasskin@chromium.org</owner> |
| + <owner>ortuno@chromium.org</owner> |
| + <owner>scheib@chromium.org</owner> |
| + <summary> |
| + Records the outcome of a call to characteristic.readValue(). Use to know |
|
Ilya Sherman
2015/08/14 22:27:50
nit: "Use to know" -> "Used to know"
ortuno
2015/08/14 22:35:03
Done.
|
| + what types of errors users are seeing. The results will be used to determine |
| + how common this errors are and if we need to provide better error messages |
|
Ilya Sherman
2015/08/14 22:27:50
nit: "this errors" -> "these errors"
ortuno
2015/08/14 22:35:03
Done.
|
| + to the users. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Bluetooth.Web.Characteristic.WriteValue.Outcome" |
| + enum="WebBluetoothGATTOperationOutcome"> |
| + <owner>jyasskin@chromium.org</owner> |
| + <owner>ortuno@chromium.org</owner> |
| + <owner>scheib@chromium.org</owner> |
| + <summary> |
| + Records the outcome of a call to characteristic.writeValue(). Use to know |
| + what types of errors users are seeing. The results will be used to determine |
| + how common this errors are and if we need to provide better error messages |
| + to the users. |
|
Ilya Sherman
2015/08/14 22:27:50
(Same nits apply here as well.)
ortuno
2015/08/14 22:35:03
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Bluetooth.Web.ConnectGATT.Outcome" |
| enum="WebBluetoothConnectGATTOutcome"> |
| <owner>jyasskin@chromium.org</owner> |
| @@ -52193,6 +52224,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </enum> |
| <enum name="BluetoothGATTErrors" type="int"> |
| + <obsolete> |
| + As of 08/2015 this has been replaced with WebBluetoothGATTOperationOutcome. |
| + </obsolete> |
| <int value="0" label="Unknown"/> |
| <int value="1" label="Failed"/> |
| <int value="2" label="In Progress"/> |
| @@ -71969,6 +72003,22 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="5" label="Characteristic.writeValue()"/> |
| </enum> |
| +<enum name="WebBluetoothGATTOperationOutcome" type="int"> |
| + <int value="0" label="Success"/> |
| + <int value="1" label="No Device"/> |
| + <int value="2" label="No Service"/> |
| + <int value="3" label="No Characteristic"/> |
| + <int value="4" label="No Descriptor"/> |
| + <int value="5" label="Unknown"/> |
| + <int value="6" label="Failed"/> |
| + <int value="7" label="In Progress"/> |
| + <int value="8" label="Invalid Length"/> |
| + <int value="9" label="Not Permitted"/> |
| + <int value="10" label="Not Authorized"/> |
| + <int value="11" label="Not Paired"/> |
| + <int value="12" label="Not Supported"/> |
| +</enum> |
| + |
| <enum name="WebBluetoothGetCharacteristicOutcome" type="int"> |
| <int value="0" label="Success"/> |
| <int value="1" label="No device"/> |