bluetooth: Add histograms for readValue and writeValue outcomes

content/browser/bluetooth/bluetooth_metrics.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_metrics.h"
 
 #include <map>
 #include <set>
 #include "base/hash.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 121 matching lines @@
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.Web.GetCharacteristic.Outcome", static_cast<int>(outcome),
       static_cast<int>(UMAGetCharacteristicOutcome::COUNT));
 }
 
 void RecordGetCharacteristicCharacteristic(const std::string& characteristic) {
   UMA_HISTOGRAM_SPARSE_SLOWLY("Bluetooth.Web.GetCharacteristic.Characteristic",
                               HashUUID(characteristic));
 }
 
-// read/write characteristic
+// GATT Operations
 
-void RecordGATTError(UMAGATTError error) {
-  UMA_HISTOGRAM_ENUMERATION("Bluetooth.GATTErrors", static_cast<int>(error),

[Jeffrey Yasskin, 2015/08/14 21:33:22]

Mark this histogram as deprecated.

[ortuno, 2015/08/14 21:42:20]

Done.

-                            static_cast<int>(UMAGATTError::MAX_ERROR));
+void RecordGATTOperationOutcome(UMAGATTOperation operation,
+                                UMAGATTOperationOutcome outcome) {
+  switch (operation) {
+    case UMAGATTOperation::CHARACTERISTIC_READ:
+      RecordCharacteristicReadValueOutcome(outcome);
+      return;
+    case UMAGATTOperation::CHARACTERISTIC_WRITE:
+      RecordCharacteristicWriteValueOutcome(outcome);
+      return;
+    case UMAGATTOperation::COUNT:
+      NOTREACHED();
+      return;
+  }
+  NOTREACHED();
+}
+
+// Characteristic.readValue
+
+// static
+void RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome outcome) {
+  UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Characteristic.ReadValue.Outcome",
+                            static_cast<int>(outcome),
+                            static_cast<int>(UMAGATTOperationOutcome::COUNT));
+}
+
+// Characteristic.writeValue
+
+void RecordCharacteristicWriteValueOutcome(UMAGATTOperationOutcome outcome) {
+  UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Characteristic.WriteValue.Outcome",
+                            static_cast<int>(outcome),
+                            static_cast<int>(UMAGATTOperationOutcome::COUNT));
 }
 
 }  // namespace content