Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294473004: DevTools: Remove proxy caching audit. (Closed)

Created:
5 years, 4 months ago by paulirish
Modified:
5 years, 4 months ago
Reviewers:
caseq, alph, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Remove proxy caching audit. Don't consider must-revalidate as uncacheable BUG=520353 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200950

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M Source/devtools/front_end/audits/AuditCategories.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 2 chunks +1 line, -41 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
paulirish
Editor of http2.0 spec pointed out our proxy caching guidance is quite incorrect. Band-aid fix ...
5 years, 4 months ago (2015-08-13 15:06:23 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-13 16:11:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294473004/1
5 years, 4 months ago (2015-08-13 16:11:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/32323)
5 years, 4 months ago (2015-08-13 16:25:45 UTC) #8
caseq
Can we get more details on how this should be properly done for future reference?
5 years, 4 months ago (2015-08-13 17:09:59 UTC) #10
paulirish
On 2015/08/13 at 17:09:59, caseq wrote: > Can we get more details on how this ...
5 years, 4 months ago (2015-08-14 18:06:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294473004/1
5 years, 4 months ago (2015-08-14 18:07:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93456)
5 years, 4 months ago (2015-08-14 20:21:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294473004/20001
5 years, 4 months ago (2015-08-20 23:07:00 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 02:22:19 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200950

Powered by Google App Engine
This is Rietveld 408576698