content/shell/android/shell_manager.h - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_manager.h

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/android/shell_manager.h

diff --git a/content/shell/android/shell_manager.h b/content/shell/android/shell_manager.h

index 93ccec4c900cdb427c8670324b3af86bc89ab1ca..e60b8c114559a50286a3d899380c5b6cbd2572a7 100644

--- a/content/shell/android/shell_manager.h

+++ b/content/shell/android/shell_manager.h

@@ -22,7 +22,7 @@ namespace content {

// window. This view holds the controls and content views necessary to

// render a shell window. Returns the java object representing the shell view.

// object.

-jobject CreateShellView(Shell* shell);

+base::android::ScopedJavaLocalRef<jobject> CreateShellView(Shell* shell);

// Removes a previously created shell view.

void RemoveShellView(jobject shell_view);