components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index 7606051f6abafb2c4e0fbd85e96625904f1c5bd6..167d2d0509c256b45fd3d71bde1f1967ff8f9e79 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -261,12 +261,9 @@ void WebContentsDelegateAndroid::WebContentsCreated(

jnew_contents = new_contents->GetJavaWebContents();

Java_WebContentsDelegateAndroid_webContentsCreated(

- env,

- obj.obj(),

- jsource_contents.obj(),

- opener_render_frame_id,

- base::android::ConvertUTF8ToJavaString(env, frame_name).Release(),

- base::android::ConvertUTF8ToJavaString(env, target_url.spec()).Release(),

+ env, obj.obj(), jsource_contents.obj(), opener_render_frame_id,

+ base::android::ConvertUTF8ToJavaString(env, frame_name).obj(),

+ base::android::ConvertUTF8ToJavaString(env, target_url.spec()).obj(),

jnew_contents.obj());

}

« no previous file with comments | « components/gcm_driver/gcm_driver_android.cc ('k') | content/shell/android/shell_manager.h » ('j') | no next file with comments »