base/android/java_handler_thread.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/java_handler_thread.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/java_handler_thread.cc

diff --git a/base/android/java_handler_thread.cc b/base/android/java_handler_thread.cc

index 117971eda5d0674468e96325d8da9286c9f20088..91c8f045341fbc6753972271fb9bf536f51299b4 100644

--- a/base/android/java_handler_thread.cc

+++ b/base/android/java_handler_thread.cc

@@ -21,7 +21,7 @@ JavaHandlerThread::JavaHandlerThread(const char* name) {

JNIEnv* env = base::android::AttachCurrentThread();

java_thread_.Reset(Java_JavaHandlerThread_create(

- env, ConvertUTF8ToJavaString(env, name).Release()));

+ env, ConvertUTF8ToJavaString(env, name).obj()));

}

JavaHandlerThread::~JavaHandlerThread() {

« no previous file with comments | « no previous file | base/android/scoped_java_ref.h » ('j') | no next file with comments »