Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1294303003: Gallery: fix coordinate calculation of viewport.js. (Closed)

Created:
5 years, 4 months ago by yawano
Modified:
5 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: fix coordinate calculation of viewport.js. We haven't considered top margin of screen when we calculate the centered rect before. This caused wrong animations of crop and rotate. BUG=521516, 521541 TEST=manually tested as described in the issues. Committed: https://crrev.com/e962293dc947e79041a1a2179e6910dec25d5315 Cr-Commit-Position: refs/heads/master@{#343835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/gallery/js/image_editor/viewport.js View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 4 months ago (2015-08-18 05:32:18 UTC) #2
hirono
lgtm
5 years, 4 months ago (2015-08-18 05:37:58 UTC) #3
yawano
On 2015/08/18 05:37:58, hirono wrote: > lgtm Thank you!
5 years, 4 months ago (2015-08-18 05:41:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294303003/1
5 years, 4 months ago (2015-08-18 05:41:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 06:24:26 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 06:25:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e962293dc947e79041a1a2179e6910dec25d5315
Cr-Commit-Position: refs/heads/master@{#343835}

Powered by Google App Engine
This is Rietveld 408576698