Use the harfbuzz version to enable hb_ot_font_set_funcs

Use the harfbuzz version to enable hb_ot_font_set_funcs

This patch checks the version of harfbuzz on the compile time to
enable the use hb_ot_font_set_funcs. With this change, the #if in the
source file no longer depends on which configurations have up-to-date
harfbuzz in the build scripts.

This gives more stable build environment, and gives the full control of
Unicode Variation Selector support to the build scripts.

[1] https://codereview.chromium.org/1283923002/

BUG=383580
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200803

[kojii, 2015-08-18 06:55:10]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2015-08-18 06:55:10]

PTAL.

Sorry for a back-and-forth on this, but the previous CL troubled a few
developers using bulidtype=Official for the development purposes.

I then found HB_VERSION_ATLEAST(), which looks the right solution to this
problem to me.

[eae, 2015-08-18 16:19:20]

LGTM

[kojii, 2015-08-18 18:05:33]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2015-08-18 18:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294303002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294303002/60001

[commit-bot: I haz the power, 2015-08-18 20:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:09:08]

Failed to apply patch for Source/platform/fonts/shaping/HarfBuzzFace.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/fonts/shaping/HarfBuzzFace.cpp
  Hunk #1 FAILED at 157.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/platform/fonts/shaping/HarfBuzzFace.cpp.rej

Patch:       Source/platform/fonts/shaping/HarfBuzzFace.cpp
Index: Source/platform/fonts/shaping/HarfBuzzFace.cpp
diff --git a/Source/platform/fonts/shaping/HarfBuzzFace.cpp
b/Source/platform/fonts/shaping/HarfBuzzFace.cpp
index
ef2aa6a18eda9ada689a4814f6794ec86b529987..5c345269de13eb618ab926ce2483c9148a98a74e
100644
--- a/Source/platform/fonts/shaping/HarfBuzzFace.cpp
+++ b/Source/platform/fonts/shaping/HarfBuzzFace.cpp
@@ -157,15 +157,16 @@ static void SkiaGetGlyphWidthAndExtents(SkPaint* paint,
hb_codepoint_t codepoint
     }
 }
 
+#if !defined(HB_VERSION_ATLEAST)
+#define HB_VERSION_ATLEAST(major, minor, micro) 0
+#endif
+
 static hb_bool_t harfBuzzGetGlyph(hb_font_t* hbFont, void* fontData,
hb_codepoint_t unicode, hb_codepoint_t variationSelector, hb_codepoint_t* glyph,
void* userData)
 {
     HarfBuzzFontData* hbFontData =
reinterpret_cast<HarfBuzzFontData*>(fontData);
 
     if (variationSelector) {
-#if OS(LINUX) && !defined(OFFICIAL_BUILD)
-        // TODO(kojii): Linux non-official builds cannot use
hb_ot_font_set_funcs()
-        // until we find a way to bundle HB in non-official builds, or pangoft2
-        // updates its HB. See crbug.com/462689.
+#if !HB_VERSION_ATLEAST(0, 9, 28)
         return false;
 #else
         // Skia does not support variation selectors, but hb does.

[kojii, 2015-08-19 04:57:17]

The CQ bit was checked by kojii@chromium.org

[kojii, 2015-08-19 04:57:17]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1294303002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-08-19 04:57:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294303002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294303002/80001

[commit-bot: I haz the power, 2015-08-19 06:34:54]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200803