chrome/browser/extensions/extension_permissions_prompt.h - Issue 12943010: Add native permissions dialog for apps_devtools app.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_permissions_prompt.h

Issue 12943010: Add native permissions dialog for apps_devtools app. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_install_prompt.h ('K') | « chrome/browser/extensions/extension_install_prompt.h ('k') | chrome/browser/extensions/extension_permissions_prompt.cc » ('j') | chrome/browser/resources/apps_debugger/js/items_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PERMISSIONS_PROMPT_H_

	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PERMISSIONS_PROMPT_H_

	7

	8 #include "chrome/browser/extensions/extension_install_prompt.h"

	9

	10 class ExtensionPermissionsPrompt : public ExtensionInstallPrompt {

	11

	12 public:

	13

	14 explicit ExtensionPermissionsPrompt(content::WebContents* contents);

	15

	16 // This WILL call Abort() on \|delegate\|.
	asargent_no_longer_on_chrome 2013/03/20 21:46:30 do you mean it will always call InstallUIAbort, do you mean it will always call InstallUIAbort, and never InstallUIProceed? Gaurav 2013/03/27 19:06:44 yes Show quoted text On 2013/03/20 21:46:30, Antony Sargent wrote: > do you mean it will always call InstallUIAbort, and never InstallUIProceed? yes
	17 virtual void PermissionsDialog(Delegate* delegate,
	asargent_no_longer_on_chrome 2013/03/20 21:46:30 Is this delegate a ExtensionInstallPrompt::Delegat Is this delegate a ExtensionInstallPrompt::Delegate? If so even if that isn't needed, it might be helpful to use the prefix just so it's clear to the reader (I scanned up looking for Delegate expecting to see it locally defined, but didn't find it). Gaurav 2013/03/27 19:06:44 Done. Show quoted text On 2013/03/20 21:46:30, Antony Sargent wrote: > Is this delegate a ExtensionInstallPrompt::Delegate? If so even if that isn't > needed, it might be helpful to use the prefix just so it's clear to the reader > (I scanned up looking for Delegate expecting to see it locally defined, but > didn't find it). Done.
	18 const extensions::Extension* extension);

	19

	20 };

	21

	22 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_PERMISSIONS_PROMPT_H_

OLD	NEW