Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issue 12943004: Deprecate HeapSnapshot type (Closed)

Created:
7 years, 9 months ago by yurys
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne, alph, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Deprecate HeapSnapshot type There is only one type of heap snapshot - kFull and we are not going to add any new types. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14005

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -53 lines) Patch
M include/v8-profiler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/api.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap-profiler.cc View 2 chunks +7 lines, -19 lines 0 comments Download
M src/heap-snapshot-generator.h View 3 chunks +1 line, -9 lines 0 comments Download
M src/heap-snapshot-generator.cc View 5 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 9 months ago (2013-03-20 09:10:23 UTC) #1
loislo
On 2013/03/20 09:10:23, Yury Semikhatsky wrote: lgtm
7 years, 9 months ago (2013-03-20 09:28:49 UTC) #2
yurys
7 years, 9 months ago (2013-03-20 12:41:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14005.

Powered by Google App Engine
This is Rietveld 408576698