content/public/browser/navigation_handle.h - Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.h

Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/navigation_params.cc ('K') | « content/common/service_worker/service_worker_utils.h ('k') | content/public/browser/navigation_handle.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/navigation_handle.h

diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h

index 2a12cb6340c9ff2987e3753de6ad803babf9fc96..4a743ec56448411877e3783d034bb826b6744de0 100644

--- a/content/public/browser/navigation_handle.h

+++ b/content/public/browser/navigation_handle.h

@@ -97,7 +97,7 @@ class CONTENT_EXPORT NavigationHandle {

static scoped_ptr<NavigationHandle> CreateNavigationHandleForTesting(

const GURL& url,

bool is_main_frame,

- WebContents* web_contents);

+ RenderFrameHost* render_frame_host);

nasko 2015/10/02 22:09:45 Does it make sense to separate this test change in

Fabrice (no longer in Chrome) 2015/10/06 17:21:38 Done.

// Registers a NavigationThrottle for tests. The throttle can

// modify the request, pause the request or cancel the request. This will