Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: content/common/navigation_params.h

Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 37b1af035401ee8e9ab394831888b68c6519e4e9..aa64b778cc843b317f879790787ae57ccb8a1744 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -13,6 +13,7 @@
#include "content/common/frame_message_enums.h"
#include "content/public/common/page_state.h"
#include "content/public/common/referrer.h"
+#include "content/public/common/request_context_type.h"
#include "ui/base/page_transition_types.h"
#include "url/gurl.h"
@@ -107,7 +108,9 @@ struct CONTENT_EXPORT BeginNavigationParams {
BeginNavigationParams(std::string method,
std::string headers,
int load_flags,
- bool has_user_gesture);
+ bool has_user_gesture,
+ bool skip_service_worker,
+ RequestContextType request_context_type);
// The request method: GET, POST, etc.
std::string method;
@@ -120,6 +123,12 @@ struct CONTENT_EXPORT BeginNavigationParams {
// True if the request was user initiated.
bool has_user_gesture;
+
+ // True if the ServiceWorker should be skipped.
+ bool skip_service_worker;
+
+ // Indicates the request context type.
+ RequestContextType request_context_type;
};
// Provided by the browser -----------------------------------------------------
@@ -257,6 +266,12 @@ struct CONTENT_EXPORT RequestNavigationParams {
// needs to notify the browser that the clearing was succesful when the
// navigation commits.
bool should_clear_history_list;
+
+ // PlzNavigate
+ // The ServiceWorkerProviderHost ID used for navigations.
+ // Set to kInvalidServiceWorkerProviderId for sandboxed frames and sync loads.
+ // This is unused for current navigation.
nasko 2015/10/02 22:09:45 Can you clarify what is meant by "current"? Is it
clamy 2015/10/05 12:18:17 +1. Something along the lines of "This parameter i
Fabrice (no longer in Chrome) 2015/10/06 17:21:38 Done in the other patch.
+ int service_worker_provider_id;
};
// Helper struct keeping track in one place of all the parameters the browser

Powered by Google App Engine
This is Rietveld 408576698