content/browser/frame_host/navigation_entry_impl.h - Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed a spot. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_entry_impl.h

diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h

index 8aec8152ba7561bee1a805969ab86ce73b054a3b..3fc337cc09f9447423aaa9c7f4b61cb365081c6c 100644

--- a/content/browser/frame_host/navigation_entry_impl.h

+++ b/content/browser/frame_host/navigation_entry_impl.h

@@ -157,7 +157,8 @@ class CONTENT_EXPORT NavigationEntryImpl

bool intended_as_new_entry,

int pending_offset_to_send,

int current_offset_to_send,

- int current_length_to_send) const;

+ int current_length_to_send,

+ int service_worker_provider_id) const;

clamy 2015/10/02 10:34:44 See my comment on the previous patch set on why we

Fabrice (no longer in Chrome) 2015/10/02 16:37:34 Done.

// Once a navigation entry is committed, we should no longer track several

// pieces of non-persisted state, as documented on the members below.

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_entry_impl.cc » ('j') | content/browser/frame_host/navigation_handle_impl.h » ('J')