content/browser/service_worker/service_worker_request_handler_unittest.cc - Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler_unittest.cc

Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_request_handler.cc ('K') | « content/browser/service_worker/service_worker_request_handler.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc » ('j') | content/child/service_worker/service_worker_network_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_request_handler_unittest.cc b/content/browser/service_worker/service_worker_request_handler_unittest.cc

index eea2edf6f32b2cd0e705bcacf8c1cb73be8f49b2..b24062c4059d22e38e6bd8fe5818d8954fd412d3 100644

--- a/content/browser/service_worker/service_worker_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_request_handler_unittest.cc

@@ -96,7 +96,7 @@ class ServiceWorkerRequestHandlerTest : public testing::Test {

FETCH_REQUEST_MODE_NO_CORS, FETCH_CREDENTIALS_MODE_OMIT,

FetchRedirectMode::FOLLOW_MODE, resource_type,

REQUEST_CONTEXT_TYPE_HYPERLINK, REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL,

- nullptr);

+ nullptr, nullptr);

return ServiceWorkerRequestHandler::GetHandler(request.get()) != nullptr;

}