PlzNavigate: Make ServiceWorker work with PlzNavigate.

content/browser/service_worker/service_worker_request_handler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REQUEST_HANDLER_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REQUEST_HANDLER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "base/supports_user_data.h"
@@ skipping 13 matching lines @@
 }
 
 namespace storage {
 class BlobStorageContext;
 }
 
 namespace content {
 
 class ResourceContext;
 class ResourceRequestBody;
+class NavigationURLLoaderImplCore;
 class ServiceWorkerContextCore;
 class ServiceWorkerContextWrapper;
 class ServiceWorkerProviderHost;
 struct ResourceResponseInfo;
 
 // Abstract base class for routing network requests to ServiceWorkers.
 // Created one per URLRequest and attached to each request.
 class CONTENT_EXPORT ServiceWorkerRequestHandler
     : public base::SupportsUserData::Data {
  public:
   // Attaches a newly created handler if the given |request| needs to
   // be handled by ServiceWorker.
   // TODO(kinuko): While utilizing UserData to attach data to URLRequest
   // has some precedence, it might be better to attach this handler in a more
   // explicit way within content layer, e.g. have ResourceRequestInfoImpl
   // own it.
   static void InitializeHandler(
       net::URLRequest* request,
       ServiceWorkerContextWrapper* context_wrapper,
       storage::BlobStorageContext* blob_storage_context,
       int process_id,
       int provider_id,
       bool skip_service_worker,
       FetchRequestMode request_mode,
       FetchCredentialsMode credentials_mode,
       FetchRedirectMode redirect_mode,
       ResourceType resource_type,
       RequestContextType request_context_type,
       RequestContextFrameType frame_type,
-      scoped_refptr<ResourceRequestBody> body);
+      scoped_refptr<ResourceRequestBody> body,
+      NavigationURLLoaderImplCore* loader);

[clamy, 2015/08/27 11:53:45]

I'm a bit concerned about providing a raw pointer to the
NavigationURLLoaderImplCore, since the URLRequest will outlive it (it gets
destroyed when the request is ready to commit). I think transitioning to a weak
pointer would avoid possible edge cases here.

[Fabrice (no longer in Chrome), 2015/08/28 15:40:16]

The loader is only used in this fashion in this method:
loader->SetServiceWorkerProviderHost(scoped_provider_host.Pass());
I don't think there is a risk of "losing" the pointer in the meantime. Or I am
misunderstanding your point.

 
   // Returns the handler attached to |request|. This may return NULL
   // if no handler is attached.
   static ServiceWorkerRequestHandler* GetHandler(
       net::URLRequest* request);
 
   // Creates a protocol interceptor for ServiceWorker.
   static scoped_ptr<net::URLRequestInterceptor> CreateInterceptor(
       ResourceContext* resource_context);
 
@@ skipping 39 matching lines @@
   scoped_ptr<ServiceWorkerProviderHost> host_for_cross_site_transfer_;
   int old_process_id_;
   int old_provider_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRequestHandler);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REQUEST_HANDLER_H_