PlzNavigate: Make ServiceWorker work with PlzNavigate.

content/browser/frame_host/navigator_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 
 #include "base/strings/string16.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_controller.h"
 #include "ui/base/page_transition_types.h"
 #include "ui/base/window_open_disposition.h"
 
 class GURL;
 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
 
 namespace content {
 
+class BrowserContext;
 class FrameTreeNode;
 class NavigationHandle;
 class RenderFrameHostImpl;
 struct LoadCommittedDetails;
 struct OpenURLParams;
 
 // A delegate API used by Navigator to notify its embedder of navigation
 // related events.
 class CONTENT_EXPORT NavigatorDelegate {
  public:
@@ skipping 93 matching lines @@
   // navigation, or triggered by history.pushState/replaceState.
   virtual void DidStartLoading(FrameTreeNode* frame_tree_node,
                                bool to_different_document) {}
 
   // A document stopped loading. This corresponds to Blink's notion of the
   // throbber stopping.
   virtual void DidStopLoading() {}
 
   // The load progress was changed.
   virtual void DidChangeLoadProgress() {}
+
+  // Helper method to access the BrowserContext.
+  virtual BrowserContext* GetBrowserContext() const;

[michaeln, 2015/10/01 23:11:12]

The NavigationController interface has a GetBrowserContext() method and the
Navigator has a navigation_controller_ data member. We should probably use that
to 'navigate' up the the browser context object.

Just curious. I see FrameTreeNodes have a reference to a Navigator. What is the
scope of a single Navigator(Impl) instance? How many nodes does a NavigatorImpl
servce concurrently and over its lifetime? From the looks of the
NavigationMetricsData, it looks like it could be a 1 to 1 relationship?

[clamy, 2015/10/02 10:34:44]

There is one NavigatorImpl per WebContents, and its lifetime is the lifetime of
the WebContents (same for the NavigationController). It services all the FTN of
the FrameTree. In this case, getting the BrowserContext through the
NavigationController is the right thing to do. In order to get to the
NavigationController, we should just keep a pointer to the FTN in the
NavigationHandle (a raw pointer is safe). In fact, it can replace the delegate
(since we can also get the Navigator and it's delegate from the FTN).

[Fabrice (no longer in Chrome), 2015/10/02 16:37:34]

Changed the argument to use a FrameTreeNode so this is removed. Thanks!

[michaeln, 2015/10/07 01:16:44]

Thnx for the explanation, the NavigationMetricsData threw me because it
obviously only applies to a single navigation. I see now that data only applies
to a navigation of the topmost frame.

 };
 
 }  // namspace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_