PlzNavigate: Make ServiceWorker work with PlzNavigate.

content/browser/frame_host/navigator_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 
 #include "base/strings/string16.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_controller.h"
 #include "ui/base/page_transition_types.h"
 #include "ui/base/window_open_disposition.h"
 
 class GURL;
 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
 
 namespace content {
 
+class BrowserContext;
 class FrameTreeNode;
 class NavigationHandle;
 class RenderFrameHostImpl;
 struct LoadCommittedDetails;
 struct OpenURLParams;
 
 // A delegate API used by Navigator to notify its embedder of navigation
 // related events.
 class CONTENT_EXPORT NavigatorDelegate {
  public:
@@ skipping 93 matching lines @@
   // navigation, or triggered by history.pushState/replaceState.
   virtual void DidStartLoading(FrameTreeNode* frame_tree_node,
                                bool to_different_document) {}
 
   // A document stopped loading. This corresponds to Blink's notion of the
   // throbber stopping.
   virtual void DidStopLoading() {}
 
   // The load progress was changed.
   virtual void DidChangeLoadProgress() {}
+
+  // Helper method to access the BrowserContext.
+  virtual BrowserContext* GetBrowserContext() const;

[michaeln, 2015/10/01 01:42:15]

This method seems out of place on this interface. Most of the method here here
have todo with the navstack telling some outside agency what's happening. This
method is not like that.

[clamy, 2015/10/01 12:41:27]

Agreed. At the end of the day, NavigatorDelegate is about the Navigator
informing the WebContents of the navigation events happening.

[Fabrice (no longer in Chrome), 2015/10/01 18:29:55]

This was the only way I found to access the BrowserContext from the
NavigationHandleImpl that did not result in an access violation somewhere.
This class is implemented as WebContentsImpl, but the presubmit prevent
including the WebContentsImpl header from frame_host (for good reasons), and I
cannot cast the NavigatorDelegate as a WebContents either.
I'd be happy to find another way of handling this.

[clamy, 2015/10/02 10:34:44]

It'd be reasonable to add a pointer to the FTN in the NavigationHandle. From
there you can get the NavigationController that will give you the
BrowserContext.

[Fabrice (no longer in Chrome), 2015/10/02 16:37:34]

Done.

 };
 
 }  // namspace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_