Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1294233004: Subtree caching implementation in blink-core (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: s/setSelfNeedsRepaint/setNeedsRepaint/ Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index c9c429ac81677e8f703528ccb03a89e71f526610..f05eed5ed5c73df3124b095fbbcad543378d49f4 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -2463,26 +2463,29 @@ void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)
ASSERT(lifecycle().state() >= DocumentLifecycle::CompositingClean);
- if (phases == AllPhases) {
- invalidateTreeIfNeededRecursive();
-
- if (view->compositor()->inCompositingMode())
- scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
+ if (phases == OnlyUpToCompositingCleanPlusScrolling)
+ return;
- updateCompositedSelectionIfNeeded();
+ invalidateTreeIfNeededRecursive();
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- paintForSlimmingPaintV2();
- compositeForSlimmingPaintV2();
- }
+ if (view->compositor()->inCompositingMode())
+ scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
- if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
- updateFrameTimingRequestsIfNeeded();
+ updateCompositedSelectionIfNeeded();
- ASSERT(!view->hasPendingSelection());
- ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean
- || (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean));
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ paintForSlimmingPaintV2();
+ if (phases == OnlyUpToPaintForSlimmingPaintV2Clean)
+ return;
+ compositeForSlimmingPaintV2();
}
+
+ if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
+ updateFrameTimingRequestsIfNeeded();
+
+ ASSERT(!view->hasPendingSelection());
+ ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean
+ || (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean));
}
}

Powered by Google App Engine
This is Rietveld 408576698