Subtree caching implementation in blink-core

Source/core/paint/DisplayItemListPaintTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "platform/graphics/paint/DisplayItemList.h"
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutText.h"
 #include "core/layout/LayoutView.h"
@@ skipping 49 matching lines @@
 public:
     DisplayItemListPaintTestForSlimmingPaintV2()
         : m_layoutView(nullptr)
         , m_originalSlimmingPaintV2Enabled(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { }
 
 protected:
     LayoutView& layoutView() { return *m_layoutView; }
     DisplayItemList& rootDisplayItemList() { return *layoutView().layer()->graphicsLayerBacking()->displayItemList(); }
     const DisplayItems& newPaintListBeforeUpdate() { return rootDisplayItemList().m_newDisplayItems; }
 
+    // Expose some document lifecycle steps.
+    void updateLifecyclePhasesToPaintForSlimmingPaintV2Clean() { document().view()->updateLifecyclePhasesInternal(FrameView::OnlyUpToPaintForSlimmingPaintV2Clean); }
+    void compositeForSlimmingPaintV2() { document().view()->compositeForSlimmingPaintV2(); }
+
 private:
     void SetUp() override
     {
         ASSERT_TRUE(RuntimeEnabledFeatures::slimmingPaintEnabled());
         RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true);
 
         RenderingTest::SetUp();
         enableCompositing();
 
         m_layoutView = document().view()->layoutView();
@@ skipping 168 matching lines @@
     InlineTextBox& secondTextBox = *newText.firstTextBox()->nextTextBox();
 
     EXPECT_DISPLAY_LIST_WITH_RED_FILL_IN_DEBUG(rootDisplayItemList().displayItems(), 5,
         TestDisplayItem(layoutView, DisplayItem::BoxDecorationBackground),
         TestDisplayItem(divBlock, DisplayItem::paintPhaseToBeginSubtreeType(PaintPhaseForeground)),
         TestDisplayItem(newFirstTextBox, DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground)),
         TestDisplayItem(secondTextBox, DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground)),
         TestDisplayItem(divBlock, DisplayItem::paintPhaseToEndSubtreeType(PaintPhaseForeground)));
 }
 
+TEST_F(DisplayItemListPaintTestForSlimmingPaintV2, SubtreeCache)

[pdr., 2015/08/20 22:45:06]

Can you add a few more tests of updating subtrees? For example, subtrees where
one phase is empty or becomes empty, and nested subtrees.

[Xianzhu, 2015/08/21 00:31:38]

This seems to test mainly the merge algorithm about subtrees, right? I'd like to
add some tests in DisplayItemListTest which can be better controlled.

+{
+    setBodyInnerHTML(
+        "<div id='container1' style='width: 200px; height: 200px; background-color: blue'>"
+        "  <div id='content1a'>AAA</div>"
+        "  <div id='content1b' style='width: 100px; height: 100px; background-color: red'>BBB</div>"
+        "</div>"
+        "<div id='container2' style='width: 200px; height: 200px; background-color: blue'>"
+        "  <div id='content2a'>CCC</div>"
+        "  <div id='content2b' style='width: 100px; height: 100px; background-color: green'>DDD</div>"
+        "</div>");
+    document().view()->updateAllLifecyclePhases();
+
+    size_t displayItemCount = rootDisplayItemList().displayItems().size();
+
+    Element& content1b = *document().getElementById("content1b");
+    content1b.setAttribute(HTMLNames::styleAttr, "width: 100px; height: 100px; background-color: green");
+
+    updateLifecyclePhasesToPaintForSlimmingPaintV2Clean();
+    const LayoutObject* container2 = document().getElementById("container2")->layoutObject();
+    int cachedSubtreeCount = 0;
+    for (auto& item : newPaintListBeforeUpdate()) {
+        if (item.isCachedSubtree()) {
+            ++cachedSubtreeCount;
+            EXPECT_EQ(container2->displayItemClient(), item.client());
+            if (cachedSubtreeCount == 1)
+                EXPECT_EQ(item.type(), DisplayItem::paintPhaseToCachedSubtreeType(PaintPhaseChildBlockBackground));
+            else if (cachedSubtreeCount == 2)
+                EXPECT_EQ(item.type(), DisplayItem::paintPhaseToCachedSubtreeType(PaintPhaseForeground));
+        }
+    }
+    EXPECT_EQ(2, cachedSubtreeCount);
+
+    compositeForSlimmingPaintV2();
+    EXPECT_EQ(displayItemCount, rootDisplayItemList().displayItems().size());
+}
+
 } // namespace blink