Forward deps to android_apk finalizer target

Forward deps to android_apk finalizer target

The android official builder is failing with this error:

Running gn 'gen' '--check' 'out/android_Official' <omitted>
ERROR Input to target not generated by a dependency.
The file:
  //out/android_Official/mojo_shell-official.keystore
is listed as an input or source for the target:
  //shell:mojo_shell_apk__create__finalize
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //shell:download_keystore

If you have generated inputs, there needs to be a dependency path between the
two targets in addition to just listing the files. For indirect dependencies,
    the intermediate ones must be public_deps. data_deps don't count since they're
    only runtime dependencies. If you think a dependency chain exists, it might be
    because the chain is private. Try "gn path" to analyze.

The //shell:mojo_shell_apk target has a dep on :download_keystore, but this dep
isn't forwarded into the finalizer rule. This forwards all deps on the create_apk
target into the finalize target which is overbroad (it includes many things that
the finalize step does not need) but includes the correct dependency as well.

R=ppi@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/16391b035c0616395e82a12ddc016c86a859c84e

[jamesr, 2015-08-17 22:14:27]

jamesr@chromium.org changed reviewers:
+ ppi@chromium.org, qsr@chromium.org

[jamesr, 2015-08-17 22:14:27]

A recent GN roll made the deps checking stricter which tripped up the android
official builder.  This patch fixes it but perhaps not in the most ideal way.

[ppi, 2015-08-18 09:16:51]

Don't we snapshot this file from Chromium? Should this land in Chromium?

The fix lgtm. We correctly add ":download_keystore" to deps of the public
android_apk rule, it seems reasonable to propagate these deps to internal
sub-targets. We already do that for other internal sub-targets of android_apk,
e.g. action(package_target).

[etiennej, 2015-08-18 09:35:04]

On 2015/08/18 09:16:51, ppi wrote:
> Don't we snapshot this file from Chromium? Should this land in Chromium?
> 
> The fix lgtm. We correctly add ":download_keystore" to deps of the public
> android_apk rule, it seems reasonable to propagate these deps to internal
> sub-targets. We already do that for other internal sub-targets of android_apk,
> e.g. action(package_target).

Same thing, I am under the impression that we snapshot this file from Chromium.
We should land this patch in chromium and then roll build/ into mojo.

[jamesr, 2015-08-19 18:05:20]

Our //build/config/... is not practically snapshottable from chromium.  I'm
going to land this to fix the bot.  If someone wishes to snapshot a new
//build/config from chromium, they should take care to land this patch first,
but I'm not planning to do that.

[jamesr, 2015-08-19 18:15:32]

Committed patchset #1 (id:1) manually as
16391b035c0616395e82a12ddc016c86a859c84e (presubmit successful).